RESOLVED FIXED Bug 54342
crypto.getRandomValues should support all integer array types 
https://bugs.webkit.org/show_bug.cgi?id=54342
Summary crypto.getRandomValues should support all integer array types
Adam Barth
Reported 2011-02-12 12:39:43 PST
crypto.getRandomValues should support all integer array types
Attachments
Patch (4.72 KB, patch)
2011-02-12 12:40 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-02-12 12:40:55 PST
Created attachment 82239 [details] Patch
Sam Weinig
Comment 2 2011-02-12 13:10:06 PST
Comment on attachment 82239 [details] Patch I haven't been paying to close attention to all this. Is this in a spec? Why VALIDATION_ERR and not a type error? Otherwise, the patch looks good.
Adam Barth
Comment 3 2011-02-12 13:14:06 PST
> I haven't been paying to close attention to all this. Is this in a spec? It's mostly been a discussion on the whatwg list. I've offered to write it up as a spec. > Why VALIDATION_ERR and not a type error? Otherwise, the patch looks good. Type error is probably better. I'll try to figure out how to throw a type error from WebCore proper.
Adam Barth
Comment 4 2011-02-12 13:20:52 PST
I see XPathException::TYPE_ERR. Is there a non-XPath specific TYPE_ERR I should be using instead?
Adam Barth
Comment 5 2011-02-12 13:21:09 PST
+sam I see XPathException::TYPE_ERR. Is there a non-XPath specific TYPE_ERR I should be using instead?
WebKit Commit Bot
Comment 6 2011-02-12 14:13:29 PST
Comment on attachment 82239 [details] Patch Clearing flags on attachment: 82239 Committed r78422: <http://trac.webkit.org/changeset/78422>
WebKit Commit Bot
Comment 7 2011-02-12 14:13:33 PST
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 8 2011-02-12 15:31:06 PST
(In reply to comment #5) > +sam > > I see XPathException::TYPE_ERR. Is there a non-XPath specific TYPE_ERR I should be using instead? TYPE_MISMATCH_ERR is what seems to be used in quite a few places, e.g. the canvas rendering context.
Note You need to log in before you can comment on or make changes to this bug.