crypto.getRandomValues should support all integer array types
Created attachment 82239 [details] Patch
Comment on attachment 82239 [details] Patch I haven't been paying to close attention to all this. Is this in a spec? Why VALIDATION_ERR and not a type error? Otherwise, the patch looks good.
> I haven't been paying to close attention to all this. Is this in a spec? It's mostly been a discussion on the whatwg list. I've offered to write it up as a spec. > Why VALIDATION_ERR and not a type error? Otherwise, the patch looks good. Type error is probably better. I'll try to figure out how to throw a type error from WebCore proper.
I see XPathException::TYPE_ERR. Is there a non-XPath specific TYPE_ERR I should be using instead?
+sam I see XPathException::TYPE_ERR. Is there a non-XPath specific TYPE_ERR I should be using instead?
Comment on attachment 82239 [details] Patch Clearing flags on attachment: 82239 Committed r78422: <http://trac.webkit.org/changeset/78422>
All reviewed patches have been landed. Closing bug.
(In reply to comment #5) > +sam > > I see XPathException::TYPE_ERR. Is there a non-XPath specific TYPE_ERR I should be using instead? TYPE_MISMATCH_ERR is what seems to be used in quite a few places, e.g. the canvas rendering context.