Bug 54331 – Finish up implementing the new event model in IndexedDB

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jeremy Orlow]

Finish up implementing the new event model in IndexedDB

[Jeremy Orlow]

Created attachment 82224 [details]
Patch

[Jeremy Orlow]

Nate, I know it's big, but don't worry...it's mostly mechanical layout test changes.  Please don't delay too long in reviewing as keeping this patch up to date will be a super bitch.

[WebKit Review Bot]

Attachment 82224 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7886848

[Early Warning System Bot]

Attachment 82224 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7870862

[Collabora GTK+ EWS bot]

Attachment 82224 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7884786

[WebKit Review Bot]

Attachment 82224 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7875832

[WebKit Review Bot]

Attachment 82224 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7875884

[Jeremy Orlow]

Created attachment 82334 [details]
patch

[WebKit Review Bot]

Attachment 82334 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7911643

[Jeremy Orlow]

Created attachment 82374 [details]
another

[Nate Chapin]

Comment on attachment 82374 [details]
another

View in context: https://bugs.webkit.org/attachment.cgi?id=82374&action=review

SO MUCH RED! :)

Just a couple of nits, and a caveat that I skimmed the ~500KB of test expectations changes.

> Source/WebCore/storage/IDBEventDispatcher.cpp:83
> +    // FIXME: "...However, we also wanted to integrate the window.onerror feature in
> +    //        HTML5. So after we've fired an "error" event, if .preventDefault() was
> +    //        never called on the event, we fire an error event on the window (can't
> +    //        remember if this happens before or after we abort the transaction).
> +    //        This is a separate event, which for example means that even if you
> +    //        attach a capturing "error" handler on window, you won't see any events
> +    //        unless an error really went unhandled. And you also can't call
> +    //        .preventDefault on the error event fired on the window in order to
> +    //        prevent the transaction from being aborted. It's purely there for
> +    //        error reporting and distinctly different from the event propagating to
> +    //        the window.
> +    //        
> +    //        This is similar to how "error" events are handled in workers.
> +    //        
> +    //        (I think that so far webkit hasn't implemented the window.onerror
> +    //        feature yet, so you probably don't want to fire the separate error
> +    //        event on the window until that has been implemented)."
> +

[citation needed]

(Sorry for not complaining when I approved it for IDBEvent.cpp).

> Source/WebCore/storage/IDBEventDispatcher.h:31
> +#ifndef IDBEventDispatcher_h
> +#define IDBEvent_h
> +

#define mismatch

[Jeremy Orlow]

Committed r78525: <http://trac.webkit.org/changeset/78525>

[WebKit Review Bot]

http://trac.webkit.org/changeset/78525 might have broken EFL Linux Release (Build)