Bug 54323 - [Freetype] Better map CSS font weight to Fontconfig font weight
Summary: [Freetype] Better map CSS font weight to Fontconfig font weight
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-02-11 16:28 PST by Martin Robinson
Modified: 2011-02-15 14:16 PST (History)
3 users (show)

See Also:

Attachments
Patch (30.96 KB, patch)
2011-02-11 16:35 PST, Martin Robinson 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-02-11 16:28:55 PST 
Right now we only make a distinction between bold and regular when mapping CSS font weight to Fontconfig font weight. This means that we don't always select the best font. We should be more discerning when asking Fontconfig for the appropriate font.
Comment 1 Martin Robinson 2011-02-11 16:35:41 PST 
Created attachment 82206 [details]
Patch
Comment 2 Xan Lopez 2011-02-11 16:40:02 PST 
Comment on attachment 82206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82206&action=review

OK.

> Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:165
> +        return FC_WEIGHT_ULTRABLACK;

ULTRA BLACK
Comment 3 Martin Robinson 2011-02-15 14:16:46 PST 
Committed r78614: <http://trac.webkit.org/changeset/78614>