Bug 54321 – [chromium] Allow turning off multisampling through web reference settings

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Zhenyao Mo]

So later we could hook up chromium side through a command line flag "--disable-gl-multisampling".

Note that I also have the chromium side CL ready for review.  I tested that with patches on both side, "--disable-gl-multisampling" will turn off multisampling in WebGL in chromium.

[Zhenyao Mo]

Created attachment 82203 [details]
Patch

[Kenneth Russell]

Comment on attachment 82203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82203&action=review

Basically looks fine with a couple of nits. Appreciate your fixing upon commit.

> Source/WebCore/ChangeLog:5
> +        [chromium] Allow turning off multisampling through web reference settings

reference -> preference

> Source/WebCore/ChangeLog:10
> +        * page/Settings.cpp: Add a fflag for multisampling preference.

typo: fflag

> Source/WebCore/ChangeLog:14
> +        (WebCore::Settings::setGLMultisamplingEnabled):
> +        * page/Settings.h: Ditto.
> +        (WebCore::Settings::GLMultisamplingEnabled):

These don't match WebKit capitalization conventions. I'd suggest "setOpenGLMultisamplingEnabled" / "openGLMultisamplingEnabled".

> Source/WebKit/chromium/ChangeLog:5
> +        [chromium] Allow turning off multisampling through web reference settings

again, reference -> preference

[Zhenyao Mo]

Committed r78419: <http://trac.webkit.org/changeset/78419>