Bug 54310 - Enable ArrayBuffers by default
Summary: Enable ArrayBuffers by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-11 13:54 PST by Adam Barth
Modified: 2011-02-12 11:09 PST (History)
9 users (show)

See Also:

Attachments
Patch (29.82 KB, patch)
2011-02-11 13:56 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (31.76 KB, patch)
2011-02-11 14:08 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
patch for win-ews to chew on (35.38 KB, patch)
2011-02-11 18:43 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
patch for win-ews to chew on (37.06 KB, patch)
2011-02-11 20:28 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
patch for win-ews to chew on (37.75 KB, patch)
2011-02-11 21:38 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
patch for win-ews to chew on (38.32 KB, patch)
2011-02-11 23:17 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-02-11 13:54:45 PST 
Enable ArrayBuffers by default
Comment 1 Adam Barth 2011-02-11 13:56:46 PST 
Created attachment 82170 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-02-11 13:59:15 PST 
Comment on attachment 82170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82170&action=review

> Source/WebCore/page/DOMWindow.idl:508
> +        attribute [JSCCustomGetter] ArrayBufferConstructor ArrayBuffer; // Usable with new operator

Why JSCCustomGetters?
Comment 3 Peter Kasting 2011-02-11 14:02:08 PST 
Should http://trac.webkit.org/changeset/78337 also get reverted in this patch?
Comment 4 Adam Barth 2011-02-11 14:03:20 PST 
(In reply to comment #2)
> (From update of attachment 82170 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82170&action=review
> 
> > Source/WebCore/page/DOMWindow.idl:508
> > +        attribute [JSCCustomGetter] ArrayBufferConstructor ArrayBuffer; // Usable with new operator
> 
> Why JSCCustomGetters?

Dunno.  That's just what was there.  We can investigate in a follow up patch.

(In reply to comment #3)
> Should http://trac.webkit.org/changeset/78337 also get reverted in this patch?

Probably.
Comment 5 WebKit Review Bot 2011-02-11 14:04:39 PST 
Attachment 82170 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7870769
Comment 6 Adam Barth 2011-02-11 14:08:54 PST 
Created attachment 82173 [details]
Patch
Comment 7 Build Bot 2011-02-11 15:15:27 PST 
Attachment 82173 [details] did not build on win:
Build output: http://queues.webkit.org/results/7869766
Comment 8 Kenneth Russell 2011-02-11 17:44:52 PST 
The changes look fine to me overall. Note that this is the first time these classes need to be compiled for the Safari Windows port (WebGL hasn't been enabled there yet), which is why they aren't in the project file and why the link failed.
Comment 9 Adam Barth 2011-02-11 18:01:04 PST 
Yeah, I'll obviously add them to the vcproj file before landing.
Comment 10 Kenneth Russell 2011-02-11 18:17:43 PST 
Comment on attachment 82173 [details]
Patch

Looks good to me then.
Comment 11 Adam Barth 2011-02-11 18:30:03 PST 
> Looks good to me then.

Thanks!
Comment 12 Adam Barth 2011-02-11 18:43:45 PST 
Created attachment 82222 [details]
patch for win-ews to chew on
Comment 13 Build Bot 2011-02-11 20:10:17 PST 
Attachment 82222 [details] did not build on win:
Build output: http://queues.webkit.org/results/7874839
Comment 14 Adam Barth 2011-02-11 20:28:56 PST 
Created attachment 82228 [details]
patch for win-ews to chew on
Comment 15 Build Bot 2011-02-11 21:08:20 PST 
Attachment 82228 [details] did not build on win:
Build output: http://queues.webkit.org/results/7875791
Comment 16 Adam Barth 2011-02-11 21:38:22 PST 
Created attachment 82229 [details]
patch for win-ews to chew on
Comment 17 Build Bot 2011-02-11 22:26:54 PST 
Attachment 82229 [details] did not build on win:
Build output: http://queues.webkit.org/results/7875810
Comment 18 Adam Barth 2011-02-11 23:16:10 PST 
Hopefully this one will work.  :)
Comment 19 Adam Barth 2011-02-11 23:17:09 PST 
Created attachment 82230 [details]
patch for win-ews to chew on
Comment 20 Adam Barth 2011-02-12 00:24:40 PST 
Committed r78407: <http://trac.webkit.org/changeset/78407>
Comment 21 Peter Kasting 2011-02-12 11:09:41 PST 
Comment on attachment 82230 [details]
patch for win-ews to chew on

Clearing r?