Bug 54310 – Enable ArrayBuffers by default

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Enable ArrayBuffers by default

[Adam Barth]

Created attachment 82170 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 82170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82170&action=review

> Source/WebCore/page/DOMWindow.idl:508
> +        attribute [JSCCustomGetter] ArrayBufferConstructor ArrayBuffer; // Usable with new operator

Why JSCCustomGetters?

[Peter Kasting]

Should http://trac.webkit.org/changeset/78337 also get reverted in this patch?

[Adam Barth]

(In reply to comment #2)
> (From update of attachment 82170 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82170&action=review
> 
> > Source/WebCore/page/DOMWindow.idl:508
> > +        attribute [JSCCustomGetter] ArrayBufferConstructor ArrayBuffer; // Usable with new operator
> 
> Why JSCCustomGetters?

Dunno.  That's just what was there.  We can investigate in a follow up patch.

(In reply to comment #3)
> Should http://trac.webkit.org/changeset/78337 also get reverted in this patch?

Probably.

[WebKit Review Bot]

Attachment 82170 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7870769

[Adam Barth]

Created attachment 82173 [details]
Patch

[Build Bot]

Attachment 82173 [details] did not build on win:
Build output: http://queues.webkit.org/results/7869766

[Kenneth Russell]

The changes look fine to me overall. Note that this is the first time these classes need to be compiled for the Safari Windows port (WebGL hasn't been enabled there yet), which is why they aren't in the project file and why the link failed.

[Adam Barth]

Yeah, I'll obviously add them to the vcproj file before landing.

[Kenneth Russell]

Comment on attachment 82173 [details]
Patch

Looks good to me then.

[Adam Barth]

> Looks good to me then.

Thanks!

[Adam Barth]

Created attachment 82222 [details]
patch for win-ews to chew on

[Build Bot]

Attachment 82222 [details] did not build on win:
Build output: http://queues.webkit.org/results/7874839

[Adam Barth]

Created attachment 82228 [details]
patch for win-ews to chew on

[Build Bot]

Attachment 82228 [details] did not build on win:
Build output: http://queues.webkit.org/results/7875791

[Adam Barth]

Created attachment 82229 [details]
patch for win-ews to chew on

[Build Bot]

Attachment 82229 [details] did not build on win:
Build output: http://queues.webkit.org/results/7875810

[Adam Barth]

Hopefully this one will work.  :)

[Adam Barth]

Created attachment 82230 [details]
patch for win-ews to chew on

[Adam Barth]

Committed r78407: <http://trac.webkit.org/changeset/78407>

[Peter Kasting]

Comment on attachment 82230 [details]
patch for win-ews to chew on

Clearing r?