Enable ArrayBuffers by default
Created attachment 82170 [details] Patch
Comment on attachment 82170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82170&action=review > Source/WebCore/page/DOMWindow.idl:508 > + attribute [JSCCustomGetter] ArrayBufferConstructor ArrayBuffer; // Usable with new operator Why JSCCustomGetters?
Should http://trac.webkit.org/changeset/78337 also get reverted in this patch?
(In reply to comment #2) > (From update of attachment 82170 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82170&action=review > > > Source/WebCore/page/DOMWindow.idl:508 > > + attribute [JSCCustomGetter] ArrayBufferConstructor ArrayBuffer; // Usable with new operator > > Why JSCCustomGetters? Dunno. That's just what was there. We can investigate in a follow up patch. (In reply to comment #3) > Should http://trac.webkit.org/changeset/78337 also get reverted in this patch? Probably.
Attachment 82170 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7870769
Created attachment 82173 [details] Patch
Attachment 82173 [details] did not build on win: Build output: http://queues.webkit.org/results/7869766
The changes look fine to me overall. Note that this is the first time these classes need to be compiled for the Safari Windows port (WebGL hasn't been enabled there yet), which is why they aren't in the project file and why the link failed.
Yeah, I'll obviously add them to the vcproj file before landing.
Comment on attachment 82173 [details] Patch Looks good to me then.
> Looks good to me then. Thanks!
Created attachment 82222 [details] patch for win-ews to chew on
Attachment 82222 [details] did not build on win: Build output: http://queues.webkit.org/results/7874839
Created attachment 82228 [details] patch for win-ews to chew on
Attachment 82228 [details] did not build on win: Build output: http://queues.webkit.org/results/7875791
Created attachment 82229 [details] patch for win-ews to chew on
Attachment 82229 [details] did not build on win: Build output: http://queues.webkit.org/results/7875810
Hopefully this one will work. :)
Created attachment 82230 [details] patch for win-ews to chew on
Committed r78407: <http://trac.webkit.org/changeset/78407>
Comment on attachment 82230 [details] patch for win-ews to chew on Clearing r?