Add a SyncMessageState class to CoreIPC::Connection
Created attachment 82168 [details] Patch
Comment on attachment 82168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82168&action=review > Source/WebKit2/Platform/CoreIPC/Connection.cpp:59 > + RunLoop* m_runLoop; > + > + typedef HashMap<RunLoop*, SyncMessageState*> SyncMessageStateMap; > + static SyncMessageStateMap& syncMessageStateMap() > + { > + DEFINE_STATIC_LOCAL(SyncMessageStateMap, syncMessageStateMap, ()); > + return syncMessageStateMap; > + } > + > + static Mutex& syncMessageStateMapMutex() > + { > + DEFINE_STATIC_LOCAL(Mutex, syncMessageStateMapMutex, ()); > + return syncMessageStateMapMutex; > + } I personally don't like function members to follow data members. > Source/WebKit2/Platform/CoreIPC/Connection.h:263 > + class SyncMessageState; > + friend class SyncMessageState; I didn't think the first declaration was necessary. But maybe it is so that the compiler knows it's a nested class?
Committed r78368: <http://trac.webkit.org/changeset/78368>
Attachment 82168 [details] did not build on win: Build output: http://queues.webkit.org/results/7870775