Bug 54298 - A little more encapsulation for the heap: Removed CollectorHeapIterator
Summary: A little more encapsulation for the heap: Removed CollectorHeapIterator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-11 11:15 PST by Geoffrey Garen
Modified: 2011-02-15 09:09 PST (History)
6 users (show)

See Also:


Attachments
Patch (21.65 KB, patch)
2011-02-11 11:26 PST, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (29.65 KB, patch)
2011-02-11 14:08 PST, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (29.65 KB, patch)
2011-02-11 14:43 PST, Geoffrey Garen
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-02-11 11:15:59 PST
A little more encapsulation for the heap: Removed CollectorHeapIterator
Comment 1 Geoffrey Garen 2011-02-11 11:26:19 PST
Created attachment 82150 [details]
Patch
Comment 2 Early Warning System Bot 2011-02-11 11:55:16 PST
Attachment 82150 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7886725
Comment 3 Build Bot 2011-02-11 12:05:21 PST
Attachment 82150 [details] did not build on win:
Build output: http://queues.webkit.org/results/7875684
Comment 4 Geoffrey Garen 2011-02-11 14:08:29 PST
Created attachment 82172 [details]
Patch
Comment 5 Early Warning System Bot 2011-02-11 14:40:10 PST
Attachment 82172 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7884690
Comment 6 Geoffrey Garen 2011-02-11 14:43:47 PST
Created attachment 82182 [details]
Patch
Comment 7 Geoffrey Garen 2011-02-11 15:31:27 PST
Committed r78382: <http://trac.webkit.org/changeset/78382>
Comment 8 Build Bot 2011-02-11 15:43:09 PST
Attachment 82172 [details] did not build on win:
Build output: http://queues.webkit.org/results/7870793
Comment 9 WebKit Review Bot 2011-02-11 15:50:36 PST
http://trac.webkit.org/changeset/78382 might have broken Qt Linux Release, Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, and Qt Windows 32-bit Release
Comment 10 Csaba Osztrogonác 2011-02-15 09:09:01 PST
(In reply to comment #9)
> http://trac.webkit.org/changeset/78382 might have broken Qt Linux Release, Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, and Qt Windows 32-bit Release

Sorry for this annoyance, it was an incremental build problem.
I filed a new bug report to fix it: https://bugs.webkit.org/show_bug.cgi?id=54466