Bug 54284 - Continues relayout on pages containing iframes when frame flattening is on
Summary: Continues relayout on pages containing iframes when frame flattening is on
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-11 07:16 PST by Piotr Roguski
Modified: 2011-08-30 22:49 PDT (History)
6 users (show)

See Also:


Attachments
archive containing iframe.html and blink.html (540 bytes, application/zip)
2011-02-11 07:16 PST, Piotr Roguski
no flags Details
patch with fix for reported issue (3.20 KB, patch)
2011-03-04 01:19 PST, Piotr Roguski
no flags Details | Formatted Diff | Diff
fixed style issue (3.19 KB, patch)
2011-03-07 06:37 PST, Piotr Roguski
tonikitoo: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Roguski 2011-02-11 07:16:43 PST
Created attachment 82132 [details]
archive containing iframe.html and blink.html

This issue affects performance. When page with nested iframes is visited, continues relayout can be observed when iframes source contains elements with padding set by styles. This issue can be reproduced only when frame flattening is on.

Steps to reproduce:
1. set frame flattening on
2. visit example site iframe.html (check attachment )

BR,
Piotrek
Comment 1 Ryuan Choi 2011-02-17 04:28:27 PST
I tested and reproduced same problem in GTK+, EFL, Qt port.
Comment 2 Piotr Roguski 2011-03-04 01:19:32 PST
Created attachment 84710 [details]
patch with fix for reported issue
Comment 3 WebKit Review Bot 2011-03-04 01:20:41 PST
Attachment 84710 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Piotr Roguski 2011-03-07 06:37:43 PST
Created attachment 84941 [details]
fixed style issue
Comment 5 Antonio Gomes 2011-04-26 17:00:38 PDT
Comment on attachment 84941 [details]
fixed style issue

View in context: https://bugs.webkit.org/attachment.cgi?id=84941&action=review

Lets add a layout test so it does not regress. If it is not possible, explain why or provide at least a manual test.

> Source/WebCore/ChangeLog:3
> +        Unreviewed

Do not change this line: leave the "Review by NOBODY (OOPS)"