Convert ContainerNode::firstElementChild() to a free function.
Created attachment 82097 [details] Patch
Comment on attachment 82097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82097&action=review > Source/WebCore/dom/Element.cpp:1657 > + return WebCore::firstElementChild(this); We don't generally use WebCore:: > Source/WebCore/dom/Element.h:518 > +inline Element* firstElementChild(const ContainerNode* container) Shouldn't Element::firstElementChild() call this? Wow, this is also one of the rare cases where a const Node* might actually be correct! (Normally such a wrong since it makes little sense to have a const* to a RefCounted object.)
Comment on attachment 82097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82097&action=review >> Source/WebCore/dom/Element.cpp:1657 >> + return WebCore::firstElementChild(this); > > We don't generally use WebCore:: I have to do that since the name in the class scope shadows the name in the namespace scope. I guess I could name the free function something else to avoid this. >> Source/WebCore/dom/Element.h:518 >> +inline Element* firstElementChild(const ContainerNode* container) > > Shouldn't Element::firstElementChild() call this? > > Wow, this is also one of the rare cases where a const Node* might actually be correct! (Normally such a wrong since it makes little sense to have a const* to a RefCounted object.) It does call it :)
Comment on attachment 82097 [details] Patch Andy, you're just so far ahead of me I can't even see you!
Comment on attachment 82097 [details] Patch Clearing flags on attachment: 82097 Committed r78317: <http://trac.webkit.org/changeset/78317>
All reviewed patches have been landed. Closing bug.