Bug 54265 - update-webkit hangs in a git-only checkout
Summary: update-webkit hangs in a git-only checkout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-10 19:02 PST by Dirk Pranke
Modified: 2011-02-14 15:59 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.57 KB, patch)
2011-02-10 19:03 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
refactor shell-callout into a subroutine per suggestion from eseidel (1.85 KB, patch)
2011-02-14 15:08 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
move isGitSvnCheckout into VCSUtils.pm, rename to isGitSVN for consistency (2.64 KB, patch)
2011-02-14 15:54 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-02-10 19:02:10 PST
update-webkit hangs in a git-only checkout
Comment 1 Dirk Pranke 2011-02-10 19:03:18 PST
Created attachment 82090 [details]
Patch
Comment 2 Dirk Pranke 2011-02-10 19:04:56 PST
dunno who the best person to review this would be ...
Comment 3 Adam Barth 2011-02-10 20:50:23 PST
Looks good to me, but +evmar for git ninja thoughts.
Comment 4 Eric Seidel (no email) 2011-02-10 21:23:02 PST
Comment on attachment 82090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82090&action=review

> Tools/Scripts/update-webkit:129
> +    if (`git config --get svn-remote.svn.fetch 2>& 1`) {

I would have made this a subroutine called isGitSVNCheckout or something.  But it's also OK.
Comment 5 Dirk Pranke 2011-02-14 15:08:22 PST
Created attachment 82369 [details]
refactor shell-callout into a subroutine per suggestion from eseidel
Comment 6 Dirk Pranke 2011-02-14 15:09:04 PST
(In reply to comment #4)
> I would have made this a subroutine called isGitSVNCheckout or something.  But it's also OK.

Good suggestion. Done.
Comment 7 Adam Barth 2011-02-14 15:30:45 PST
Comment on attachment 82369 [details]
refactor shell-callout into a subroutine per suggestion from eseidel

My git foo isn't that strong, but dpranke tell me evmar has blessed this incantation.  One question: do we want to declare this function at the top of the file?
Comment 8 Dirk Pranke 2011-02-14 15:31:37 PST
I will add the declaration.
Comment 9 Dirk Pranke 2011-02-14 15:54:39 PST
Created attachment 82376 [details]
move isGitSvnCheckout into VCSUtils.pm, rename to isGitSVN for consistency
Comment 10 Dirk Pranke 2011-02-14 15:59:57 PST
Committed r78520: <http://trac.webkit.org/changeset/78520>