update-webkit hangs in a git-only checkout
Created attachment 82090 [details] Patch
dunno who the best person to review this would be ...
Looks good to me, but +evmar for git ninja thoughts.
Comment on attachment 82090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82090&action=review > Tools/Scripts/update-webkit:129 > + if (`git config --get svn-remote.svn.fetch 2>& 1`) { I would have made this a subroutine called isGitSVNCheckout or something. But it's also OK.
Created attachment 82369 [details] refactor shell-callout into a subroutine per suggestion from eseidel
(In reply to comment #4) > I would have made this a subroutine called isGitSVNCheckout or something. But it's also OK. Good suggestion. Done.
Comment on attachment 82369 [details] refactor shell-callout into a subroutine per suggestion from eseidel My git foo isn't that strong, but dpranke tell me evmar has blessed this incantation. One question: do we want to declare this function at the top of the file?
I will add the declaration.
Created attachment 82376 [details] move isGitSvnCheckout into VCSUtils.pm, rename to isGitSVN for consistency
Committed r78520: <http://trac.webkit.org/changeset/78520>