WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
54265
update-webkit hangs in a git-only checkout
https://bugs.webkit.org/show_bug.cgi?id=54265
Summary
update-webkit hangs in a git-only checkout
Dirk Pranke
Reported
2011-02-10 19:02:10 PST
update-webkit hangs in a git-only checkout
Attachments
Patch
(1.57 KB, patch)
2011-02-10 19:03 PST
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
refactor shell-callout into a subroutine per suggestion from eseidel
(1.85 KB, patch)
2011-02-14 15:08 PST
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
move isGitSvnCheckout into VCSUtils.pm, rename to isGitSVN for consistency
(2.64 KB, patch)
2011-02-14 15:54 PST
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2011-02-10 19:03:18 PST
Created
attachment 82090
[details]
Patch
Dirk Pranke
Comment 2
2011-02-10 19:04:56 PST
dunno who the best person to review this would be ...
Adam Barth
Comment 3
2011-02-10 20:50:23 PST
Looks good to me, but +evmar for git ninja thoughts.
Eric Seidel (no email)
Comment 4
2011-02-10 21:23:02 PST
Comment on
attachment 82090
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=82090&action=review
> Tools/Scripts/update-webkit:129 > + if (`git config --get svn-remote.svn.fetch 2>& 1`) {
I would have made this a subroutine called isGitSVNCheckout or something. But it's also OK.
Dirk Pranke
Comment 5
2011-02-14 15:08:22 PST
Created
attachment 82369
[details]
refactor shell-callout into a subroutine per suggestion from eseidel
Dirk Pranke
Comment 6
2011-02-14 15:09:04 PST
(In reply to
comment #4
)
> I would have made this a subroutine called isGitSVNCheckout or something. But it's also OK.
Good suggestion. Done.
Adam Barth
Comment 7
2011-02-14 15:30:45 PST
Comment on
attachment 82369
[details]
refactor shell-callout into a subroutine per suggestion from eseidel My git foo isn't that strong, but dpranke tell me evmar has blessed this incantation. One question: do we want to declare this function at the top of the file?
Dirk Pranke
Comment 8
2011-02-14 15:31:37 PST
I will add the declaration.
Dirk Pranke
Comment 9
2011-02-14 15:54:39 PST
Created
attachment 82376
[details]
move isGitSvnCheckout into VCSUtils.pm, rename to isGitSVN for consistency
Dirk Pranke
Comment 10
2011-02-14 15:59:57 PST
Committed
r78520
: <
http://trac.webkit.org/changeset/78520
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug