The patch in https://bugs.webkit.org/show_bug.cgi?id=53442 caused this clang warning: In file included from out/Debug/obj/gen/webkit/bindings/V8DerivedSources3.cpp:90: In file included from out/Debug/obj/gen/webcore/bindings/V8SVGCircleElement.cpp:22: In file included from out/Debug/obj/gen/webkit/bindings/V8SVGCircleElement.h:26: In file included from third_party/WebKit/Source/WebCore/svg/SVGCircleElement.h:29: In file included from third_party/WebKit/Source/WebCore/svg/SVGStyledTransformableElement.h:26: In file included from third_party/WebKit/Source/WebCore/svg/SVGStyledLocatableElement.h:26: third_party/WebKit/Source/WebCore/svg/SVGStyledElement.h:71:10:error: 'WebCore::SVGStyledElement::fillAttributeToPropertyTypeMap' hides overloaded virtual function [-Woverloaded-virtual] void fillAttributeToPropertyTypeMap(AttributeToPropertyTypeMap&); ^ In file included from out/Debug/obj/gen/webkit/bindings/V8DerivedSources3.cpp:90: In file included from out/Debug/obj/gen/webcore/bindings/V8SVGCircleElement.cpp:22: In file included from out/Debug/obj/gen/webkit/bindings/V8SVGCircleElement.h:26: In file included from third_party/WebKit/Source/WebCore/svg/SVGCircleElement.h:25: In file included from third_party/WebKit/Source/WebCore/svg/SVGAnimatedBoolean.h:24: In file included from third_party/WebKit/Source/WebCore/svg/properties/SVGAnimatedStaticPropertyTearOff.h:24: In file included from third_party/WebKit/Source/WebCore/svg/properties/SVGAnimatedProperty.h:26: third_party/WebKit/Source/WebCore/svg/SVGElement.h:93:18: note: hidden overloaded virtual function 'WebCore::SVGElement::fillAttributeToPropertyTypeMap' declared here virtual void fillAttributeToPropertyTypeMap() { } ^ 1 error generated. I'm not sure if SVGStyledElement::fillAttributeToPropertyTypeMap is supposed to override SVGElement::fillAttributeToPropertyTypeMap…if not, I'd recommend renaming the method in the subclass. Having an overload of a virtual method of a base class is confusing at best. This is currently the only place in webkit that triggers this warning.
Created attachment 82110 [details] Patch
Comment on attachment 82110 [details] Patch r=me
Committed r78345: <http://trac.webkit.org/changeset/78345>