Bug 54245 - Cached JavaScript Parser Data Being Left in Memory Cache
Summary: Cached JavaScript Parser Data Being Left in Memory Cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-10 14:29 PST by Michael Saboff
Modified: 2011-02-10 18:10 PST (History)
1 user (show)

See Also:


Attachments
Patch to release SourceProviderCache data from MemoryCache (6.81 KB, patch)
2011-02-10 15:03 PST, Michael Saboff
no flags Details | Formatted Diff | Diff
Updated Patch with Windows export of SourceProviderCache::clear() (7.52 KB, patch)
2011-02-10 16:13 PST, Michael Saboff
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2011-02-10 14:29:41 PST
SourceProviderCache data is being left in the MemoryCache for CachedScript objects.
Comment 1 Michael Saboff 2011-02-10 15:03:30 PST
Created attachment 82055 [details]
Patch to release SourceProviderCache data from MemoryCache
Comment 2 Build Bot 2011-02-10 15:37:05 PST
Attachment 82055 [details] did not build on win:
Build output: http://queues.webkit.org/results/7868463
Comment 3 Michael Saboff 2011-02-10 16:13:11 PST
Created attachment 82068 [details]
Updated Patch with Windows export of SourceProviderCache::clear()
Comment 4 Geoffrey Garen 2011-02-10 16:15:42 PST
Comment on attachment 82068 [details]
Updated Patch with Windows export of SourceProviderCache::clear()

View in context: https://bugs.webkit.org/attachment.cgi?id=82068&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        Added logic in CachedScript to clear SourceProviderCache data in

I think it's worth mentioning the improvement you measured on membuster, for the benefit of future readers.

> Source/WebCore/loader/cache/CachedScript.cpp:129
> -    // FIXME: SourceInfoCache should be wiped out too but not this easily.
> +    if (m_sourceProviderCache)
> +        m_sourceProviderCache->clear();

I thought this juxtaposition was cool :).
Comment 5 Oliver Hunt 2011-02-10 16:23:14 PST
Comment on attachment 82068 [details]
Updated Patch with Windows export of SourceProviderCache::clear()

View in context: https://bugs.webkit.org/attachment.cgi?id=82068&action=review

>> Source/WebCore/loader/cache/CachedScript.cpp:129
>> +    if (m_sourceProviderCache)
>> +        m_sourceProviderCache->clear();
> 
> I thought this juxtaposition was cool :).

You should be able to just do m_sourceProviderCache.clear()
Comment 6 Michael Saboff 2011-02-10 18:10:42 PST
Committed r78297: <http://trac.webkit.org/changeset/78297>