Bug 54240 – [Qt] Fix assert in QDeclarativeWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Ademar Reis]

From:
http://bugreports.qt.nokia.com/browse/QTBUG-14278

In a debug build this will trigger an assert:

import QtWebKit 1.0

WebView {
  width: 640
  height: 480
  WebView {
  }
}

Patch for webkit (based on the patch already submited to Qt) is on the way.

[Ademar Reis]

Created attachment 82036 [details]
patch

[WebKit Review Bot]

Attachment 82036 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1

Source/WebKit/qt/declarative/qdeclarativewebview.cpp:252:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebKit/qt/declarative/qdeclarativewebview.cpp:253:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebKit/qt/declarative/qdeclarativewebview.cpp:254:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 82036 [details]
patch

Clearing flags on attachment: 82036

Committed r78269: <http://trac.webkit.org/changeset/78269>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ademar Reis]

Revision r78269 cherry-picked into qtwebkit-2.1 with commit 96da807 <http://gitorious.org/webkit/qtwebkit/commit/96da807>

[Ademar Reis]

Revision r78269 cherry-picked into qtwebkit-2.0 with commit 61982c8 <http://gitorious.org/webkit/qtwebkit/commit/61982c8>