Bug 54228 - Fix style in KURLGooglePrivate
Summary: Fix style in KURLGooglePrivate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 53749
  Show dependency treegraph
 
Reported: 2011-02-10 11:34 PST by Cosmin Truta
Modified: 2011-02-10 17:01 PST (History)
2 users (show)

See Also:


Attachments
Patch (8.94 KB, patch)
2011-02-10 13:45 PST, Cosmin Truta
no flags Details | Formatted Diff | Diff
Patch (8.94 KB, patch)
2011-02-10 13:51 PST, Cosmin Truta
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cosmin Truta 2011-02-10 11:34:09 PST
check-webkit-style currently fails on KURLGooglePrivate.h and KURLGoogle.cpp. 'nuff said.
Comment 1 Cosmin Truta 2011-02-10 13:45:17 PST
Created attachment 82040 [details]
Patch

I replaced "NULL" with "0", "'\0'" or "null" as appropriate. I kept using the (dictionary word) "null" because it makes sense to refer to the "null string", and also because it has semantic meaning in the underlying classes (e.g. CString::isNull).
Comment 2 Cosmin Truta 2011-02-10 13:51:38 PST
Created attachment 82043 [details]
Patch

Same patch as before, with a typo fixed.
Comment 3 WebKit Commit Bot 2011-02-10 17:01:43 PST
Comment on attachment 82043 [details]
Patch

Clearing flags on attachment: 82043

Committed r78289: <http://trac.webkit.org/changeset/78289>
Comment 4 WebKit Commit Bot 2011-02-10 17:01:48 PST
All reviewed patches have been landed.  Closing bug.