WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
54211
WKPageFindClient::didFindString is never called if kWKFindOptionsShowOverlay is not passed to WKPageFindString
https://bugs.webkit.org/show_bug.cgi?id=54211
Summary
WKPageFindClient::didFindString is never called if kWKFindOptionsShowOverlay ...
Adam Roben (:aroben)
Reported
2011-02-10 07:55:46 PST
If an application calls WKPageFindString, but doesn't pass the kWKFindOptionsShowOverlay flag, the find client's didFindString callback is never called. You can see in the implementation of FindController::findString that the DidFindString message is only sent if shouldShowOverlay is true. [1] It seems like either didFindString is misnamed, or we should be calling it even when we're not showing the overlay. 1.
http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp?rev=77862#L104
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug