RESOLVED FIXED 54205
Web Inspector: [STYLES] Suggest CSS property values once Up/Down is pressed with an empty input 
https://bugs.webkit.org/show_bug.cgi?id=54205
Summary Web Inspector: [STYLES] Suggest CSS property values once Up/Down is pressed w...
Alexander Pavlov (apavlov)
Reported Thursday, February 10, 2011 2:26:19 PM UTC
Currently nothing happens, but a user should be able to cycle through available values even without entering anything, just pressing Up/Down.
Attachments
[PATCH] Suggested solution (4.27 KB, patch)
2011-02-10 06:49 PST, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
[PATCH] Comment addressed (4.36 KB, patch)
2011-02-10 07:35 PST, Alexander Pavlov (apavlov) 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 Thursday, February 10, 2011 2:49:03 PM UTC
Created attachment 81973 [details] [PATCH] Suggested solution
Alexander Pavlov (apavlov)
Comment 2 Thursday, February 10, 2011 2:53:35 PM UTC
Upstreaming http://code.google.com/p/chromium/issues/detail?id=40784 request regarding empty value auto-completion.
Yury Semikhatsky
Comment 3 Thursday, February 10, 2011 3:27:21 PM UTC
Comment on attachment 81973 [details] [PATCH] Suggested solution View in context: https://bugs.webkit.org/attachment.cgi?id=81973&action=review > Source/WebCore/inspector/front-end/TextPrompt.js:201 > + if ((auto ^ (selectionRange.commonAncestorContainer !== this.element)) && !selectionRange.commonAncestorContainer.isDescendant(this.element)) This expression looks too complex to me. Can you break it down into some simpler pieces?
Alexander Pavlov (apavlov)
Comment 4 Thursday, February 10, 2011 3:35:06 PM UTC
Created attachment 81980 [details] [PATCH] Comment addressed
Alexander Pavlov (apavlov)
Comment 5 Thursday, February 10, 2011 4:05:35 PM UTC
Landed with a variable extracted, as suggested by Yury. Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/CSSCompletions.js M Source/WebCore/inspector/front-end/CSSKeywordCompletions.js M Source/WebCore/inspector/front-end/StylesSidebarPane.js M Source/WebCore/inspector/front-end/TextPrompt.js Committed r78225
Note You need to log in before you can comment on or make changes to this bug.