Bug 54203 – [GTK] http/tests/websocket/tests/handshake-fail-by-maxlength.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

The timeout there expires too early sometimes. That test needs a refactoring, using body.onload.

[Philippe Normand]

Created attachment 81967 [details]
proposed patch

[Joe Mason]

Not a reviewer, but LGTM

[Martin Robinson]

Comment on attachment 81967 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81967&action=review

Hrm. Wouldn't putting the timeout and description into startTest remove the flakiness as well. I guess I'm not exactly sure what the issue was.

> LayoutTests/http/tests/websocket/tests/handshake-fail-by-maxlength.html:15
> +var successfullyParsed = true;

I think this needs to be the last line of JavaScript.

[Philippe Normand]

The issue is that the timer is fired too late. Starting it just after the body loaded, like in some other tests, seemed to fix the issue. At least locally.

I tried setting the description in startTest() but then there was an error about an undefined variable, I don't recall which exactly

[Philippe Normand]

Anyway, some time after that failure I saw a bunch of other websocket tests failing again and just decided to skip them all. Xan backed me up on this.

[Martin Robinson]

Comment on attachment 81967 [details]
proposed patch

r- for the previously mentioned issue.

[Eric Seidel (no email)]

Adam moved the websocket tests over to a real http server and most of the flakiness went away. If you see this again, please re-open.

[Philippe Normand]

Committed r85469: <http://trac.webkit.org/changeset/85469>

[Philippe Normand]

Sorry I meant r85470