Bug 54198 – [GTK] Log signals from AtkDocument interface also in AccessibilityController

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mario Sanchez Prada]

Apart from logging all activity related to the AtkObject's signals being emitted, it would be useful as well to log those signals being emitted by objects implementing the AtkDocument interface.

Among other things, it would probably help to write a good layout test for patch for bug 25831, instead of having to work around the situation through a unit test.

[Mario Sanchez Prada]

I forgot to mention what exactly I'd like to get added in there. It would be the following signals:

  - load-complete
  - load-stopped
  - reload

http://library.gnome.org/devel/atk/unstable/AtkDocument.html#AtkDocument.signals

[Mario Sanchez Prada]

Created attachment 81976 [details]
Patch proposal

Patch proposal.

I've also made the most of this patch to fix some static functions and parameters names which were not following the code convention before (oops!)

[Martin Robinson]

Comment on attachment 81976 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=81976&action=review

Great. Please incorporate the following suggestions.

> Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp:36
> +#include "DumpRenderTree.h"
> +#include "WebCoreSupport/DumpRenderTreeSupportGtk.h"
> +
> +#include <gtk/gtk.h>

No empty line needed here.

> Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp:65
> +    gchar* actualObjectName = 0;
> +    if (!objectName || *objectName == '\0')
> +        actualObjectName = g_strdup("(No name)");
> +    else
> +        actualObjectName = g_strdup(objectName);
> +

I think you can just do this:
if (!objectName || *objectName == '\0')
    objectName = "No name";

and avoid some extra code.

> Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp:86
> +    gchar* signalName = 0;

You can use GOwnPtr here.

> Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp:102
> +    } else {
> +        signalName = g_strdup(signal_query.signal_name);
> +    }

No curlies here since this is only one line.

[Mario Sanchez Prada]

Committed r78244: <http://trac.webkit.org/changeset/78244>