Created attachment 81958 [details]
Some fields are needed on ResourceRequest and ResourceResponse so that WebURLResponse and WebURLRequest data is passed down to the client supplied URLLoader. This is in preparation for a later patch to add CORS support to AssociatedURLLoader.
Attachment 81958 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/network/chromium/ResourceResponse.h:101: Tab found; better to use spaces [whitespace/tab] 
Source/WebCore/platform/network/chromium/ResourceResponse.h:156: Tab found; better to use spaces [whitespace/tab] 
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 81960 [details]
Found some style errors
Comment on attachment 81960 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=81960&action=review
The change looks great an I was tempted to r+/cq+ it but I'm curious about why these fields are needed in order to add CORS support to AssociatedURLLoader. Would you just give a short explanation of this? (I don't need anything in depth just something to give me the idea.)
> +2011-02-10 billbudge <firstname.lastname@example.org>
Is "billbudge" instead of "Bill Budge" intentional?
These fields are needed because the WebURLRequest and WebURLResponse classes have these, and they need to get transferred down through the WebCore layers to reach the actual WebURLLoader that the WebKitClient::createURLLoader() method provides. Without this change, .nexe loading didn't work.
Created attachment 81996 [details]
Fix my name on the ChangeLog
Comment on attachment 81996 [details]
Clearing flags on attachment: 81996
Committed r78253: <http://trac.webkit.org/changeset/78253>
All reviewed patches have been landed. Closing bug.