Bug 54195 - Web Inspector: refactoring, extract SourceMapping from SourceFrameContent
Summary: Web Inspector: refactoring, extract SourceMapping from SourceFrameContent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-10 05:28 PST by Pavel Podivilov
Modified: 2011-02-14 06:06 PST (History)
10 users (show)

See Also:


Attachments
Patch. (25.67 KB, patch)
2011-02-10 05:31 PST, Pavel Podivilov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-02-10 05:28:03 PST
Web Inspector: refactoring, extract SourceMapping from SourceFrameContent.
This will allow supporting JS compiler source mappings without changing SourceFrameContent or SourceFrame code.
Comment 1 Pavel Podivilov 2011-02-10 05:31:42 PST
Created attachment 81957 [details]
Patch.
Comment 2 Yury Semikhatsky 2011-02-11 02:04:48 PST
Comment on attachment 81957 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=81957&action=review

> Source/WebCore/inspector/front-end/ScriptFormatter.js:200
> +    fromScriptLocation: function(lineNumber, columnNumber)

The method name is confusing, should be something like originalToFormattedLocation

> Source/WebCore/inspector/front-end/ScriptFormatter.js:206
> +    toScriptLocation: function(lineNumber, columnNumber)

Ditto.
Comment 3 Pavel Podivilov 2011-02-14 06:06:58 PST
Committed r78472: <http://trac.webkit.org/changeset/78472>