Bug 54188 - Remove PCRE source from trunk
Summary: Remove PCRE source from trunk
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Peter Varga
Depends on:
Reported: 2011-02-10 02:42 PST by Peter Varga
Modified: 2011-02-10 07:49 PST (History)
7 users (show)

See Also:

proposed patch (400.10 KB, patch)
2011-02-10 02:58 PST, Peter Varga
no flags Details | Formatted Diff | Diff
proposed patch v2 (400.21 KB, patch)
2011-02-10 04:17 PST, Peter Varga
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Varga 2011-02-10 02:42:14 PST
The PCRE library isn't used anymore. The remaining sources and entries in project files should be removed.
Comment 1 Peter Varga 2011-02-10 02:58:06 PST
Created attachment 81943 [details]
proposed patch
Comment 2 Collabora GTK+ EWS bot 2011-02-10 04:04:20 PST
Attachment 81943 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7886273
Comment 3 Csaba Osztrogonác 2011-02-10 04:08:54 PST
Comment on attachment 81943 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81943&action=review

> Source/JavaScriptCore/GNUmakefile.am:-52
>  	Source/JavaScriptCore/runtime/StringPrototype.lut.h \
> -	Source/JavaScriptCore/pcre/chartables.c

Please remove the last backslash:
Comment 4 Peter Varga 2011-02-10 04:17:26 PST
Created attachment 81949 [details]
proposed patch v2
Comment 5 Csaba Osztrogonác 2011-02-10 04:47:40 PST
Comment on attachment 81949 [details]
proposed patch v2

Great work Peter! We don't need pcre anymore, r=me.

Unfortunately EWS bots can't apply vcproj changes because of different line breaks. :(
Please make sure you don't break any build, and watch the buildbots. ;)
Comment 6 Csaba Osztrogonác 2011-02-10 07:45:29 PST
Landed in http://trac.webkit.org/changeset/78211