only erase draft comments after publish is successful
Created attachment 81916 [details] Patch
Comment on attachment 81916 [details] Patch What happens if there's a mid-air collision?
(In reply to comment #2) > (From update of attachment 81916 [details]) > What happens if there's a mid-air collision? You'll get the mid-air collision page in an iframe. You can continue with the submit or cancel. If you cancel, the iframe will navigate back to the bug page. To get back to the review you'll need to refresh the review page, which will have all your comments safely stored. :)
Is the iframe visible? I is confused.
(In reply to comment #4) > Is the iframe visible? I is confused. Yes. It's the reviewform iframe. I'll try to upload a screenshot.
Comment on attachment 81916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81916&action=review > Websites/bugs.webkit.org/ChangeLog:13 > + Once WebKit supports seamless iframes we should be able to avoid Dummy comment.
Whoops. Screenshot preparation fail.
Comment on attachment 81916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81916&action=review > Websites/bugs.webkit.org/code-review.js:1040 > + // This is the intial load of the review form iframe. Don't publish!
(In reply to comment #7) > Whoops. Screenshot preparation fail. Ahh. Sorry for the noise.
Comment on attachment 81916 [details] Patch Looks like the review form doesn't hit mid-air collissions? I just publishes anyways.
> Looks like the review form doesn't hit mid-air collissions? I just publishes anyways. It will hit a mid-air collision if someone modifies the attachment while the review is in flight.
Created attachment 82096 [details] publish when not logged in
Sorry for all the noise. I wish bugzilla would let you delete comments. Anyways, it looks like you don't get a mid-air collision when there is a review conflict, it just publishes it anyways. For the case where you're not logged in though, we popup the iframe as I described. I attached a screenshot. From within the iframe you can then login and complete publishing.
Comment on attachment 81916 [details] Patch I'm slightly scared of this misbehaving, but I like the concept. If there are bugs, we can fix them.
Committed r78310: <http://trac.webkit.org/changeset/78310>