Bug 54160 - REGRESSION (r77101) box-shadow sometimes renders incorrectly
Summary: REGRESSION (r77101) box-shadow sometimes renders incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-09 19:11 PST by Simon Fraser (smfr)
Modified: 2011-02-09 21:16 PST (History)
1 user (show)

See Also:

Attachments
Testcase (527 bytes, text/html)
2011-02-09 19:11 PST, Simon Fraser (smfr) 		no flags Details
Patch (15.61 KB, patch)
2011-02-09 21:02 PST, Simon Fraser (smfr) 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-02-09 19:11:02 PST 
Created attachment 81912 [details]
Testcase

The attached testcase shows an issue where a box-shadow gets drawn incorrectly behind another element sometimes.
Comment 1 Simon Fraser (smfr) 2011-02-09 20:29:10 PST 
The bug is that endShadowLayer() does

    graphicsContext->clipToImageBuffer(m_layerImage, FloatRect(m_layerOrigin, m_layerImage->size()));

but not all of m_layerImage->size() was cleared, so may contains bits from some previous shadow.
Comment 2 Simon Fraser (smfr) 2011-02-09 21:02:21 PST 
Created attachment 81918 [details]
Patch
Comment 3 Simon Fraser (smfr) 2011-02-09 21:16:34 PST 
http://trac.webkit.org/changeset/78173