Bug 54159 - REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
Summary: REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-op...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-02-09 18:35 PST by Maciej Stachowiak
Modified: 2011-04-11 21:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.77 KB, patch)
2011-04-11 19:01 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2011-02-09 18:35:03 PST 
Ever since http://trac.webkit.org/changeset/77974, the test http/tests/security/aboutBlank/security-context-window-open.html is failing.
Comment 1 Maciej Stachowiak 2011-02-09 18:35:32 PST 
<rdar://problem/8981346>
Comment 2 Sam Weinig 2011-04-11 19:01:09 PDT 
Created attachment 89145 [details]
Patch
Comment 3 WebKit Review Bot 2011-04-11 19:03:10 PDT 
Attachment 89145 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Tools/WebKitTestRunner/TestController.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Early Warning System Bot 2011-04-11 19:07:57 PDT 
Attachment 89145 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8393099
Comment 5 Sam Weinig 2011-04-11 19:10:20 PDT 
Committed r83550: <http://trac.webkit.org/changeset/83550>
Comment 6 Daniel Bates 2011-04-11 21:57:50 PDT 
(In reply to comment #4)
> Attachment 89145 [details] did not build on qt:
> Build output: http://queues.webkit.org/results/8393099

As prophesied by the Qt EWS bot ( :-( ), this change broke the Qt Linux Release build:

<http://build.webkit.org/builders/Qt%20Linux%20Release/builds/31231/steps/compile-webkit/logs/stdio>
Comment 7 Daniel Bates 2011-04-11 21:58:21 PDT 
Committed build fix for Qt Linux Release bot in changeset 83556 <http://trac.webkit.org/changeset/83556>.