RESOLVED FIXED 54149
[chromium] add WebIDBObjectStore::clear method 
https://bugs.webkit.org/show_bug.cgi?id=54149
Summary [chromium] add WebIDBObjectStore::clear method
jochen
Reported 2011-02-09 15:16:57 PST
[chromium] add WebIDBObjectStore::clear method
Attachments
Patch (1.72 KB, patch)
2011-02-09 15:17 PST, jochen 		jorlow: review+
jorlow: commit-queue-
DetailsFormatted DiffDiff
Patch (2.13 KB, patch)
2011-02-10 01:02 PST, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2011-02-09 15:17:16 PST
Created attachment 81882 [details] Patch
jochen
Comment 2 2011-02-09 15:17:47 PST
This implements http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBObjectStore-clear Jeremy, is there a meta bug this should block?
Jeremy Orlow
Comment 3 2011-02-09 16:22:16 PST
Comment on attachment 81882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81882&action=review r=me > Source/WebKit/chromium/public/WebIDBObjectStore.h:72 > + virtual void clear(WebIDBCallbacks* callbacks, const WebIDBTransaction& transaction, WebExceptionCode& ec) { WEBKIT_ASSERT_NOT_REACHED(); } don't include names (can you fix the others please?)
Darin Fisher (:fishd, Google)
Comment 4 2011-02-09 22:40:51 PST
> > Source/WebKit/chromium/public/WebIDBObjectStore.h:72 > > + virtual void clear(WebIDBCallbacks* callbacks, const WebIDBTransaction& transaction, WebExceptionCode& ec) { WEBKIT_ASSERT_NOT_REACHED(); } > > don't include names (can you fix the others please?) Just to clarify, the rule is that you should exclude parameter names that do not add information. In this case, the parameter names are all based on the type names, so they can be excluded. You should name parameters when it is helpful to do so. For example, if a function takes a bool or int parameter, it is often helpful to give that parameter a descriptive name.
jochen
Comment 5 2011-02-10 01:02:56 PST
Created attachment 81936 [details] Patch
WebKit Commit Bot
Comment 6 2011-02-10 05:06:18 PST
Comment on attachment 81936 [details] Patch Clearing flags on attachment: 81936 Committed r78207: <http://trac.webkit.org/changeset/78207>
Note You need to log in before you can comment on or make changes to this bug.