RESOLVED FIXED 54129
A tiny bit of encapsulation for MarkedBlock: made its heap data member private 
https://bugs.webkit.org/show_bug.cgi?id=54129
Summary A tiny bit of encapsulation for MarkedBlock: made its heap data member private
Geoffrey Garen
Reported 2011-02-09 12:02:55 PST
A tiny bit of encapsulation for MarkedBlock: made its heap data member private
Attachments
Patch (3.61 KB, patch)
2011-02-09 12:04 PST, Geoffrey Garen 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-02-09 12:04:02 PST
Created attachment 81847 [details] Patch
Sam Weinig
Comment 2 2011-02-09 12:06:42 PST
Comment on attachment 81847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81847&action=review > Source/JavaScriptCore/runtime/MarkedBlock.h:62 > + Heap* heap(); Please make const.
Geoffrey Garen
Comment 3 2011-02-09 12:09:50 PST
Committed r78105: <http://trac.webkit.org/changeset/78105>
WebKit Review Bot
Comment 4 2011-02-09 12:18:28 PST
http://trac.webkit.org/changeset/78105 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Windows 32-bit Release, and EFL Linux Release (Build)
Gustavo Noronha (kov)
Comment 5 2011-02-09 12:59:04 PST
Attachment 81847 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7874026
Note You need to log in before you can comment on or make changes to this bug.