Bug 54129 - A tiny bit of encapsulation for MarkedBlock: made its heap data member private
Summary: A tiny bit of encapsulation for MarkedBlock: made its heap data member private
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-09 12:02 PST by Geoffrey Garen
Modified: 2011-02-09 12:59 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.61 KB, patch)
2011-02-09 12:04 PST, Geoffrey Garen
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-02-09 12:02:55 PST
A tiny bit of encapsulation for MarkedBlock: made its heap data member private
Comment 1 Geoffrey Garen 2011-02-09 12:04:02 PST
Created attachment 81847 [details]
Patch
Comment 2 Sam Weinig 2011-02-09 12:06:42 PST
Comment on attachment 81847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81847&action=review

> Source/JavaScriptCore/runtime/MarkedBlock.h:62
> +        Heap* heap();

Please make const.
Comment 3 Geoffrey Garen 2011-02-09 12:09:50 PST
Committed r78105: <http://trac.webkit.org/changeset/78105>
Comment 4 WebKit Review Bot 2011-02-09 12:18:28 PST
http://trac.webkit.org/changeset/78105 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Windows 32-bit Release, and EFL Linux Release (Build)
Comment 5 Gustavo Noronha (kov) 2011-02-09 12:59:04 PST
Attachment 81847 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7874026