WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
Bug 54127
[chromium] rebaseline tool does not follows fallback sequence in Mac
https://bugs.webkit.org/show_bug.cgi?id=54127
Summary
[chromium] rebaseline tool does not follows fallback sequence in Mac
Xiaomei Ji
Reported
2011-02-09 11:54:50 PST
Chromium mac bot runs on Leopard. The fallback sequence is
http://google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&q=baseline_search_path&exact_package=chromium&sa=N&cd=8&ct=rc
. If chromium-mac result is different from result in mac-leopard/, but the same as result in mac/, instead of rebaseline the chromium-mac result, rebaseline tool ignores this txt file (seems precedes mac over mac-leopard). For an example: pop-up-button-text-alignment-and-direction has different expected results in mac and mac-leopard, its txt result in chromium-mac is the same as that in mac/, rebaseline tool will not rebase this txt file in chromium-mac. But the bot will show the test as failure. 110209 10:10:05 rebaseline_chromium_webkit_tests.py:91 INFO ------------------- Extracting and adding new baselines: mac ------------------- 110209 10:10:28 rebaseline_chromium_webkit_tests.py:354 INFO Test 1: fast/text/international/pop-up-button-text-alignment-and-direction.html 110209 10:10:28 rebaseline_chromium_webkit_tests.py:369 INFO .txt file found in archive. 110209 10:10:28 rebaseline_chromium_webkit_tests.py:456 INFO Found same baseline at /Volumes/leopard/export/chromium/src/third_party/WebKit/LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt 110209 10:10:28 rebaseline_chromium_webkit_tests.py:365 INFO .png file not in archive.
Attachments
Add attachment
proposed patch, testcase, etc.
Mihai Parparita
Comment 1
2011-02-11 11:10:28 PST
Dirk, will your patch on
bug 54248
fix this too?
Dirk Pranke
Comment 2
2011-02-11 18:59:33 PST
theoretically, yes, I think so.
Stephen Chenney
Comment 3
2013-04-09 16:10:34 PDT
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug