%subj%
Created attachment 81804 [details] [patch] initial version
Comment on attachment 81804 [details] [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=81804&action=review > Source/WebCore/inspector/InspectorAgent.cpp:202 > + m_domAgent->setDocument(m_inspectedPage->mainFrame()->document()); While you are here, please nuke setDocument call here - it is done from within pushDataCollectedOffline. > Source/WebCore/inspector/InspectorController.cpp:117 > + m_inspectorAgent->disconnectFrontend(); InspectorAgent::disconnectFrontend is manipulating front-end. Hence it should be called before the m_inspectorFrontend.clear() above. > Source/WebCore/inspector/InspectorController.cpp:146 > + if (!m_inspectorFrontend) Now that you know that front-end does not exist, why checking for m_inspectorFrontend here?
Created attachment 81809 [details] [patch] second version comments addressed
Created attachment 81815 [details] [patch] second version with assert
Comment on attachment 81815 [details] [patch] second version with assert Clearing flags on attachment: 81815 Committed r78056: <http://trac.webkit.org/changeset/78056>
All reviewed patches have been landed. Closing bug.