RESOLVED FIXED 54098
Web Inspector: [regression] Fix syncing heights of the gutter and main panel lines, and add 2px padding-left 
https://bugs.webkit.org/show_bug.cgi?id=54098
Summary Web Inspector: [regression] Fix syncing heights of the gutter and main panel ...
Andrey Adaikin
Reported 2011-02-09 06:54:48 PST
1) Syncing heights of the gutter and main panel lines some times can not be done right away (for example, if the textViewer has not been shown yet in the Web Inspector). Thus we should always sync the height when we repaint the screen. 2) Remove the 2px space between the gutter and mail panels, instead use "padding-left: 2px" for the mail panel.
Attachments
Patch (4.49 KB, patch)
2011-02-09 06:58 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Patch (7.01 KB, patch)
2011-02-10 03:11 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Patch (7.25 KB, patch)
2011-02-10 03:40 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Patch (7.52 KB, patch)
2011-02-10 04:43 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Patch (7.59 KB, patch)
2011-02-10 05:15 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2011-02-09 06:58:10 PST
Created attachment 81803 [details] Patch
Pavel Feldman
Comment 2 2011-02-09 07:08:54 PST
Comment on attachment 81803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81803&action=review > Source/WebCore/inspector/front-end/TextViewer.js:166 > + gutterChunk.element.style.height = ""; I am not sure what setting integer property to "" is supposed to do. You should use setProperty and removeProperty on style object instead.
Andrey Adaikin
Comment 3 2011-02-10 03:10:10 PST
Comment on attachment 81803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81803&action=review >> Source/WebCore/inspector/front-end/TextViewer.js:166 >> + gutterChunk.element.style.height = ""; > > I am not sure what setting integer property to "" is supposed to do. You should use setProperty and removeProperty on style object instead. done
Andrey Adaikin
Comment 4 2011-02-10 03:11:29 PST
Created attachment 81945 [details] Patch
Andrey Adaikin
Comment 5 2011-02-10 03:40:58 PST
Created attachment 81947 [details] Patch
Andrey Adaikin
Comment 6 2011-02-10 04:43:58 PST
Created attachment 81951 [details] Patch
Andrey Adaikin
Comment 7 2011-02-10 05:15:27 PST
Created attachment 81954 [details] Patch
Pavel Podivilov
Comment 8 2011-02-10 05:41:11 PST
Comment on attachment 81954 [details] Patch Clearing flags on attachment: 81954 Committed r78210: <http://trac.webkit.org/changeset/78210>
Pavel Podivilov
Comment 9 2011-02-10 05:41:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.