Bug 54098 - Web Inspector: [regression] Fix syncing heights of the gutter and main panel lines, and add 2px padding-left
Summary: Web Inspector: [regression] Fix syncing heights of the gutter and main panel ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-09 06:54 PST by Andrey Adaikin
Modified: 2011-02-10 05:41 PST (History)
11 users (show)

See Also:

Attachments
Patch (4.49 KB, patch)
2011-02-09 06:58 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Patch (7.01 KB, patch)
2011-02-10 03:11 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Patch (7.25 KB, patch)
2011-02-10 03:40 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Patch (7.52 KB, patch)
2011-02-10 04:43 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Patch (7.59 KB, patch)
2011-02-10 05:15 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2011-02-09 06:54:48 PST 
1) Syncing heights of the gutter and main panel lines some times can not be done right away (for example, if the textViewer has not been shown yet in the Web Inspector). Thus we should always sync the height when we repaint the screen.

2) Remove the 2px space between the gutter and mail panels, instead use "padding-left: 2px" for the mail panel.
Comment 1 Andrey Adaikin 2011-02-09 06:58:10 PST 
Created attachment 81803 [details]
Patch
Comment 2 Pavel Feldman 2011-02-09 07:08:54 PST 
Comment on attachment 81803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81803&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:166
> +            gutterChunk.element.style.height = "";

I am not sure what setting integer property to "" is supposed to do. You should use setProperty and removeProperty on style object instead.
Comment 3 Andrey Adaikin 2011-02-10 03:10:10 PST 
Comment on attachment 81803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81803&action=review

>> Source/WebCore/inspector/front-end/TextViewer.js:166
>> +            gutterChunk.element.style.height = "";
> 
> I am not sure what setting integer property to "" is supposed to do. You should use setProperty and removeProperty on style object instead.

done
Comment 4 Andrey Adaikin 2011-02-10 03:11:29 PST 
Created attachment 81945 [details]
Patch
Comment 5 Andrey Adaikin 2011-02-10 03:40:58 PST 
Created attachment 81947 [details]
Patch
Comment 6 Andrey Adaikin 2011-02-10 04:43:58 PST 
Created attachment 81951 [details]
Patch
Comment 7 Andrey Adaikin 2011-02-10 05:15:27 PST 
Created attachment 81954 [details]
Patch
Comment 8 Pavel Podivilov 2011-02-10 05:41:11 PST 
Comment on attachment 81954 [details]
Patch

Clearing flags on attachment: 81954

Committed r78210: <http://trac.webkit.org/changeset/78210>
Comment 9 Pavel Podivilov 2011-02-10 05:41:20 PST 
All reviewed patches have been landed.  Closing bug.