Bug 54092 – Extra separator after Select All in context menu

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Christian Dywan]

There is an extra separator after Select All in the context menu.

[Christian Dywan]

Created attachment 81794 [details]
Move spelling option menu separator to non-GTK+port guards

The separator comes from the spelling option menu which the GTK+ port doesn't show. So the separator needs to be moved into non-GTK+ port guards.

[Gustavo Noronha (kov)]

Comment on attachment 81794 [details]
Move spelling option menu separator to non-GTK+port guards

View in context: https://bugs.webkit.org/attachment.cgi?id=81794&action=review

> Source/WebCore/page/ContextMenuController.cpp:894
>  #ifndef BUILDING_ON_TIGER
>  #if !PLATFORM(GTK)
> +            appendItem(*separatorItem(), m_contextMenu.get());

This looks right ot me, but we're also affecting Mac here. Although it does look like it would work as intended for them as well, better check with someone from mac land.

[Brent Fulgham]

Comment on attachment 81794 [details]
Move spelling option menu separator to non-GTK+port guards

View in context: https://bugs.webkit.org/attachment.cgi?id=81794&action=review

>> Source/WebCore/page/ContextMenuController.cpp:894
>> +            appendItem(*separatorItem(), m_contextMenu.get());
> 
> This looks right ot me, but we're also affecting Mac here. Although it does look like it would work as intended for them as well, better check with someone from mac land.

This may not do the right thing for Tiger builds.  The append will only happen for more recent OS versions, but perhaps no one cares anymore?

[Eric Seidel (no email)]

Comment on attachment 81794 [details]
Move spelling option menu separator to non-GTK+port guards

Looks fine.  If this doesn't break anything in the CQ, it's fine.  Please let the cq land it to be sure.

[WebKit Commit Bot]

Comment on attachment 81794 [details]
Move spelling option menu separator to non-GTK+port guards

Clearing flags on attachment: 81794

Committed r84983: <http://trac.webkit.org/changeset/84983>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.