Bug 54089 – Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view.

[Andrey Adaikin]

Created attachment 82126 [details]
Patch

[Pavel Podivilov]

(In reply to comment #1)
> Created an attachment (id=82126) [details]
> Patch

Looks good.

[Pavel Feldman]

Comment on attachment 82126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82126&action=review

> Source/WebCore/ChangeLog:5
> +        Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view

It is not clear why this regressed. Could you please put more info into the change log?

> Source/WebCore/inspector/front-end/Drawer.js:183
> +            this.mainStatusBar.insertBefore(anchoredItems, this.mainStatusBar.firstChild);

These should be private (this._main ...)

[Andrey Adaikin]

Comment on attachment 82126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82126&action=review

>> Source/WebCore/ChangeLog:5
>> +        Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view
> 
> It is not clear why this regressed. Could you please put more info into the change log?

I also have no idea why it worked before (and when it got broken). Would you like me to invest my time into finding the reason? Otherwise, logically by this CL I just make sure that the console drawer is in the right position by the time when the revealLine() is called (before it was in an animation process, thus the revealLine() calls were missed).

[Pavel Feldman]

I guess it is fine, just make properties private!

[Andrey Adaikin]

Created attachment 82139 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 82139 [details]
Patch

Clearing flags on attachment: 82139

Committed r78343: <http://trac.webkit.org/changeset/78343>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Andrey Adaikin]

This issue also exists in the latest Chrome 10.0.648.45 dev, which uses 76408 WebKit revision, and it does not include my change that replaced TABLE in favor of DIVs (which was landed at http://trac.webkit.org/changeset/77375).

So Pavel, seems like you were right, this is not a regression.