Bug 54089 - Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view
Summary: Web Inspector: [REGRESSION] click on error message in console doesn't scroll ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-09 04:09 PST by Pavel Podivilov
Modified: 2011-02-13 06:50 PST (History)
11 users (show)

See Also:


Attachments
Patch (10.70 KB, patch)
2011-02-11 06:03 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff
Patch (16.05 KB, patch)
2011-02-11 09:11 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-02-09 04:09:10 PST
Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view.
Comment 1 Andrey Adaikin 2011-02-11 06:03:53 PST
Created attachment 82126 [details]
Patch
Comment 2 Pavel Podivilov 2011-02-11 06:12:09 PST
(In reply to comment #1)
> Created an attachment (id=82126) [details]
> Patch

Looks good.
Comment 3 Pavel Feldman 2011-02-11 06:32:14 PST
Comment on attachment 82126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82126&action=review

> Source/WebCore/ChangeLog:5
> +        Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view

It is not clear why this regressed. Could you please put more info into the change log?

> Source/WebCore/inspector/front-end/Drawer.js:183
> +            this.mainStatusBar.insertBefore(anchoredItems, this.mainStatusBar.firstChild);

These should be private (this._main ...)
Comment 4 Andrey Adaikin 2011-02-11 08:34:44 PST
Comment on attachment 82126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82126&action=review

>> Source/WebCore/ChangeLog:5
>> +        Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view
> 
> It is not clear why this regressed. Could you please put more info into the change log?

I also have no idea why it worked before (and when it got broken). Would you like me to invest my time into finding the reason? Otherwise, logically by this CL I just make sure that the console drawer is in the right position by the time when the revealLine() is called (before it was in an animation process, thus the revealLine() calls were missed).
Comment 5 Pavel Feldman 2011-02-11 08:43:26 PST
I guess it is fine, just make properties private!
Comment 6 Andrey Adaikin 2011-02-11 09:11:45 PST
Created attachment 82139 [details]
Patch
Comment 7 WebKit Commit Bot 2011-02-11 09:43:33 PST
Comment on attachment 82139 [details]
Patch

Clearing flags on attachment: 82139

Committed r78343: <http://trac.webkit.org/changeset/78343>
Comment 8 WebKit Commit Bot 2011-02-11 09:43:38 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Andrey Adaikin 2011-02-13 06:50:02 PST
This issue also exists in the latest Chrome 10.0.648.45 dev, which uses 76408 WebKit revision, and it does not include my change that replaced TABLE in favor of DIVs (which was landed at http://trac.webkit.org/changeset/77375).

So Pavel, seems like you were right, this is not a regression.