Bug 54081 - [GTK] Implement WKBaseGtk API for Webkit2
Summary: [GTK] Implement WKBaseGtk API for Webkit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 52805
  Show dependency tree / graph
 
Reported: 2011-02-09 01:37 PST by Alejandro G. Castro
Modified: 2011-02-09 13:23 PST (History)
3 users (show)

See Also:

Attachments
Proposed patch (14.51 KB, patch)
2011-02-09 06:20 PST, Alejandro G. Castro 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2011-02-09 01:37:49 PST 
We have to add C API to create the gtk widget.
Comment 1 Alejandro G. Castro 2011-02-09 06:20:48 PST 
Created attachment 81795 [details]
Proposed patch
Comment 2 Martin Robinson 2011-02-09 08:33:44 PST 
Comment on attachment 81795 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81795&action=review

> Source/WebKit2/ChangeLog:5
> +        Based on patch by Chandra Vallala.

You probably want to move this name to the top line and use 'and'.
Comment 3 Alejandro G. Castro 2011-02-09 09:36:19 PST 
(In reply to comment #2)
> (From update of attachment 81795 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81795&action=review
> 
> > Source/WebKit2/ChangeLog:5
> > +        Based on patch by Chandra Vallala.
> 
> You probably want to move this name to the top line and use 'and'.

Yep, sorry about that.
Comment 4 Alejandro G. Castro 2011-02-09 09:46:27 PST 
Landed http://trac.webkit.org/changeset/78072
Comment 5 WebKit Review Bot 2011-02-09 13:23:13 PST 
http://trac.webkit.org/changeset/78072 might have broken GTK Linux 64-bit Debug