Bug 54074 – nrwt multiprocessing: add in per-worker, per-shard stats

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

nrwt multiprocessing: add in per-worker, per-shard stats

[Dirk Pranke]

Created attachment 81764 [details]
Patch

[Ojan Vafai]

Comment on attachment 81764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81764&action=review

Just a couple minor things.

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:157
> +        thread_timings = [w.stats for w in self._workers.values()]

s/w/worker

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:218
> +    def _update_worker_stats(self, src, result, elapsed_time):

You don't use result here.

[Dirk Pranke]

Created attachment 82219 [details]
merge in changes from 54070, 54071, 54072, update w/ ojan's feedback

[Tony Chang]

Comment on attachment 82219 [details]
merge in changes from 54070, 54071, 54072, update w/ ojan's feedback

View in context: https://bugs.webkit.org/attachment.cgi?id=82219&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:62
> +        self.stats = {}
> +        self.stats['name'] = worker_connection.name
> +        self.stats['num_tests'] = 0
> +        self.stats['total_time'] = 0

Nit: I would declare this inline, but I don't feel strongly about it.  Someday we should convert this to a class.
self.stats = {
    'name': worker_connection.name,
    'num_tests': 0,
    'total_time': 0,
}

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:211
> +        self._group_stats[list_name] = (num_tests, elapsed_time)
>          pass

Remove 'pass'

[Dirk Pranke]

(In reply to comment #4)
> (From update of attachment 82219 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82219&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:62
> > +        self.stats = {}
> > +        self.stats['name'] = worker_connection.name
> > +        self.stats['num_tests'] = 0
> > +        self.stats['total_time'] = 0
> 
> Nit: I would declare this inline, but I don't feel strongly about it.  Someday we should convert this to a class.
> self.stats = {
>     'name': worker_connection.name,
>     'num_tests': 0,
>     'total_time': 0,
> }
> 

There's actually no good reason to keep this a separate data structure rather than just hanging the fields directly off of WorkerState, but I didn't want to mess with the surrounding code. I will merge that in a subsequent patch after all of this other stuff lands.

[Dirk Pranke]

Committed r78507: <http://trac.webkit.org/changeset/78507>