Bug 54059 - Crash when going back/forward when back/forward list is in a bad state.
Summary: Crash when going back/forward when back/forward list is in a bad state.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-08 21:18 PST by Maciej Stachowiak
Modified: 2011-02-08 21:40 PST (History)
0 users

See Also:


Attachments
Patch (1.69 KB, patch)
2011-02-08 21:20 PST, Maciej Stachowiak
no flags Details | Formatted Diff | Diff
Patch (2.35 KB, patch)
2011-02-08 21:36 PST, Maciej Stachowiak
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2011-02-08 21:18:20 PST
Crash when going back/forward when back/forward list is in a bad state.
Comment 1 Maciej Stachowiak 2011-02-08 21:20:38 PST
Created attachment 81742 [details]
Patch
Comment 2 Mark Rowe (bdash) 2011-02-08 21:26:11 PST
Comment on attachment 81742 [details]
Patch

Local variables for m_backForwardList->forwardItem() and m_backForwardList->backItem() could make this clearer since each of those is called four times within the function.
Comment 3 Maciej Stachowiak 2011-02-08 21:36:29 PST
Created attachment 81743 [details]
Patch
Comment 4 Maciej Stachowiak 2011-02-08 21:40:20 PST
Committed r78015: <http://trac.webkit.org/changeset/78015>