Bug 54057 – [GTK] Build break with 2.18.3

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Ryuan Choi]

I got below error message and I realized that GTK+2.18.3 doesn't have gtk_range_get_min_slider_size.
But configure.ac indicate GTK_REQUIRED_VERSION as 2.10.

Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp: In member function ‘void WebCore::ScrollbarThemeGtk::updateThemeProperties()’:
Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp:62:74: error: ‘gtk_range_get_min_slider_size’ was not declared in this scope
  CXX    Source/WebCore/platform/gtk/libwebkitgtk_1_0_la-WidgetGtk.lo
  CXX    Source/WebCore/platform/gtk/libwebkitgtk_1_0_la-WidgetRenderingContext.lo
  CXX    Source/WebCore/platform/image-decoders/bmp/libwebkitgtk_1_0_la-BMPImageDecoder.lo
  CXX    Source/WebCore/platform/image-decoders/bmp/libwebkitgtk_1_0_la-BMPImageReader.lo
  CXX    Source/WebCore/platform/image-decoders/cairo/libwebkitgtk_1_0_la-ImageDecoderCairo.lo
make[1]: *** [Source/WebCore/platform/gtk/libwebkitgtk_1_0_la-ScrollbarThemeGtk2.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/workspace/gtk_webkit'
make: *** [all] Error 2

[Ryuan Choi]

Created attachment 82075 [details]
Patch

[Martin Robinson]

Comment on attachment 82075 [details]
Patch

I believe you can just include GtkVersioning.h in the RenderThemeGtk2.cpp.

[Ryuan Choi]

Created attachment 82081 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 82081 [details]
Patch

Clearing flags on attachment: 82081

Committed r78320: <http://trac.webkit.org/changeset/78320>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.