Bug 54045 - Fix scaling and thread safety of FFTFrameFFTW
Summary: Fix scaling and thread safety of FFTFrameFFTW
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-08 16:20 PST by Chris Rogers
Modified: 2011-02-09 12:03 PST (History)
1 user (show)

See Also:

Attachments
Patch (6.90 KB, patch)
2011-02-08 16:25 PST, Chris Rogers 		no flags Details | Formatted Diff | Diff
Patch (9.82 KB, patch)
2011-02-08 17:27 PST, Chris Rogers 		no flags Details | Formatted Diff | Diff
Patch (9.61 KB, patch)
2011-02-08 17:30 PST, Chris Rogers 		kbr: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-02-08 16:20:53 PST 
Fix scaling and thread safety of FFTFrameFFTW
Comment 1 Chris Rogers 2011-02-08 16:25:05 PST 
Created attachment 81714 [details]
Patch
Comment 2 Kenneth Russell 2011-02-08 17:01:38 PST 
Comment on attachment 81714 [details]
Patch

This mostly looks good -- thanks for fixing my bugs -- but as we discussed offline we should add a static initialize() method to FFTFrame to allow the mutex to be created from a known good place, before multithreaded allocation of FFTFrames might start.
Comment 3 Chris Rogers 2011-02-08 17:27:49 PST 
Created attachment 81722 [details]
Patch
Comment 4 Chris Rogers 2011-02-08 17:30:57 PST 
Created attachment 81723 [details]
Patch
Comment 5 Chris Rogers 2011-02-08 17:31:54 PST 
Added the static initialize() method.
Comment 6 Kenneth Russell 2011-02-08 17:34:46 PST 
Comment on attachment 81723 [details]
Patch

Looks fine. Please regenerate the ChangeLog when landing to pick up the changes to newly modified files.
Comment 7 Chris Rogers 2011-02-09 12:03:38 PST 
Committed r78102: <http://trac.webkit.org/changeset/78102>