Bug 54038 – [GTK] Menulists do not follow text direction when rendering options with right-to-left text

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

This appears to be an issue with the values we return from ChromeClient::selectItemWritingDirectionIsNatural and ChromeClient::selectItemAlignmentFollowsMenuWritingDirection.

[Martin Robinson]

Created attachment 81704 [details]
Patch

[Martin Robinson]

Comment on attachment 81704 [details]
Patch

Removing r?, as I think this patch is incomplete.

[Martin Robinson]

Created attachment 81712 [details]
Patch

[Xan Lopez]

Comment on attachment 81712 [details]
Patch

The rationale behind this change seems a bit obscure in general. I guess at the very least you should say why do you want to do this.

[Martin Robinson]

(In reply to comment #4)
> (From update of attachment 81712 [details])
> The rationale behind this change seems a bit obscure in general. I guess at the very least you should say why do you want to do this.

I can update the ChangeLog to say something like:

Do not follow the natural writing direction of menu list text, but do follow the menu list writing direction. This matches the behavior of Chromium and modern OS X machines. This will mean that the menulist text-alignment will override the natural bidi alignment of the text.

[Xiaomei Ji]

(In reply to comment #4)
> (From update of attachment 81712 [details])
> The rationale behind this change seems a bit obscure in general. I guess at the very least you should say why do you want to do this.

It is proposed and accepted in HTML5
http://dev.w3.org/html5/spec/Overview.html#text-rendered-in-native-user-interfaces

[Eric Seidel (no email)]

Comment on attachment 81712 [details]
Patch

OK.

[WebKit Commit Bot]

Comment on attachment 81712 [details]
Patch

Rejecting attachment 81712 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2

Last 500 characters of output:
k FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej
patching file LayoutTests/platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum
LayoutTests/platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png already exists at /Projects/CommitQueue/Tools/Scripts/svn-apply line 253.

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 25

Full output: http://queues.webkit.org/results/8511165

[Martin Robinson]

Committed r85066: <http://trac.webkit.org/changeset/85066>