Bug 54038 - [GTK] Menulists do not follow text direction when rendering options with right-to-left text
Summary: [GTK] Menulists do not follow text direction when rendering options with righ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-02-08 14:53 PST by Martin Robinson
Modified: 2011-04-27 11:22 PDT (History)
3 users (show)

See Also:


Attachments
Patch (63.42 KB, patch)
2011-02-08 15:00 PST, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (66.04 KB, patch)
2011-02-08 16:20 PST, Martin Robinson
eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-02-08 14:53:24 PST
This appears to be an issue with the values we return from ChromeClient::selectItemWritingDirectionIsNatural and ChromeClient::selectItemAlignmentFollowsMenuWritingDirection.
Comment 1 Martin Robinson 2011-02-08 15:00:02 PST
Created attachment 81704 [details]
Patch
Comment 2 Martin Robinson 2011-02-08 15:34:35 PST
Comment on attachment 81704 [details]
Patch

Removing r?, as I think this patch is incomplete.
Comment 3 Martin Robinson 2011-02-08 16:20:00 PST
Created attachment 81712 [details]
Patch
Comment 4 Xan Lopez 2011-04-01 16:02:01 PDT
Comment on attachment 81712 [details]
Patch

The rationale behind this change seems a bit obscure in general. I guess at the very least you should say why do you want to do this.
Comment 5 Martin Robinson 2011-04-01 16:10:32 PDT
(In reply to comment #4)
> (From update of attachment 81712 [details])
> The rationale behind this change seems a bit obscure in general. I guess at the very least you should say why do you want to do this.

I can update the ChangeLog to say something like:

Do not follow the natural writing direction of menu list text, but do follow the menu list writing direction. This matches the behavior of Chromium and modern OS X machines. This will mean that the menulist text-alignment will override the natural bidi alignment of the text.
Comment 6 Xiaomei Ji 2011-04-04 10:50:48 PDT
(In reply to comment #4)
> (From update of attachment 81712 [details])
> The rationale behind this change seems a bit obscure in general. I guess at the very least you should say why do you want to do this.

It is proposed and accepted in HTML5
http://dev.w3.org/html5/spec/Overview.html#text-rendered-in-native-user-interfaces
Comment 7 Eric Seidel (no email) 2011-04-26 15:22:21 PDT
Comment on attachment 81712 [details]
Patch

OK.
Comment 8 WebKit Commit Bot 2011-04-26 15:24:55 PDT
Comment on attachment 81712 [details]
Patch

Rejecting attachment 81712 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2

Last 500 characters of output:
k FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej
patching file LayoutTests/platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum
LayoutTests/platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png already exists at /Projects/CommitQueue/Tools/Scripts/svn-apply line 253.

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 25

Full output: http://queues.webkit.org/results/8511165
Comment 9 Martin Robinson 2011-04-27 11:22:15 PDT
Committed r85066: <http://trac.webkit.org/changeset/85066>