Bug 54017 - drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
Summary: drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-08 09:54 PST by Zhenyao Mo
Modified: 2011-02-08 11:34 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.65 KB, patch)
2011-02-08 10:24 PST, Zhenyao Mo
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2011-02-08 09:54:02 PST
WebGL spec says: " If count is greater than zero, then a non-null WebGLBuffer must be bound to the ELEMENT_ARRAY_BUFFER binding point or an INVALID_OPERATION error will be generated."

We should avoid sending down the call to underlying GL if no buffer is bound to the ELEMENT_ARRAY_BUFFER.
Comment 1 Zhenyao Mo 2011-02-08 10:24:37 PST
Created attachment 81658 [details]
Patch
Comment 2 Kenneth Russell 2011-02-08 10:28:36 PST
Comment on attachment 81658 [details]
Patch

Looks good.
Comment 3 Zhenyao Mo 2011-02-08 10:50:44 PST
Landed in http://trac.webkit.org/changeset/77956
Comment 4 WebKit Review Bot 2011-02-08 11:34:50 PST
http://trac.webkit.org/changeset/77956 might have broken Qt Linux Release
The following tests are not passing:
http/tests/websocket/tests/workers/close-in-onmessage-crash.html