RESOLVED FIXED 54009
[WK2] LayerTreeContext is used outside the ACCELERATED_COMPOSITING guards but not defined in DrawingAreaProxy.h 
https://bugs.webkit.org/show_bug.cgi?id=54009
Summary [WK2] LayerTreeContext is used outside the ACCELERATED_COMPOSITING guards but...
Alejandro G. Castro
Reported Tuesday, February 8, 2011 4:56:11 PM UTC
After r77546 LayerTreeContext is used outside the ACCELERATED_COMPOSITING guards: diff --git a/Source/WebKit2/UIProcess/DrawingAreaProxy.h b/Source/WebKit2/UIProcess/DrawingAreaProxy.h index 1639668..0e3b555 100644 --- a/Source/WebKit2/UIProcess/DrawingAreaProxy.h +++ b/Source/WebKit2/UIProcess/DrawingAreaProxy.h @@ -97,7 +97,7 @@ private: // CoreIPC message handlers. // FIXME: These should be pure virtual. virtual void update(uint64_t sequenceNumber, const UpdateInfo&) { } - virtual void didSetSize(uint64_t sequenceNumber, const UpdateInfo&) { } + virtual void didSetSize(uint64_t sequenceNumber, const UpdateInfo&, const LayerTreeContext&) { } #if USE(ACCELERATED_COMPOSITING) virtual void enterAcceleratedCompositingMode(uint64_t sequenceNumber, const LayerTreeContext&) { } virtual void exitAcceleratedCompositingMode(uint64_t sequenceNumber) { } But it is forward declared inside the guards in the same file.
Attachments
Proposed patch (1.77 KB, patch)
2011-02-08 09:03 PST, Alejandro G. Castro 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 Tuesday, February 8, 2011 5:03:35 PM UTC
Created attachment 81643 [details] Proposed patch
Alejandro G. Castro
Comment 2 Wednesday, February 9, 2011 7:22:41 AM UTC
Landed http://trac.webkit.org/changeset/78021
Note You need to log in before you can comment on or make changes to this bug.