Bug 54009 - [WK2] LayerTreeContext is used outside the ACCELERATED_COMPOSITING guards but not defined in DrawingAreaProxy.h
Summary: [WK2] LayerTreeContext is used outside the ACCELERATED_COMPOSITING guards but...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 52805
  Show dependency tree / graph
 
Reported: 2011-02-08 08:56 PST by Alejandro G. Castro
Modified: 2011-02-08 23:22 PST (History)
2 users (show)

See Also:

Attachments
Proposed patch (1.77 KB, patch)
2011-02-08 09:03 PST, Alejandro G. Castro 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2011-02-08 08:56:11 PST 
After r77546 LayerTreeContext is used outside the ACCELERATED_COMPOSITING guards:

diff --git a/Source/WebKit2/UIProcess/DrawingAreaProxy.h b/Source/WebKit2/UIProcess/DrawingAreaProxy.h
index 1639668..0e3b555 100644
--- a/Source/WebKit2/UIProcess/DrawingAreaProxy.h
+++ b/Source/WebKit2/UIProcess/DrawingAreaProxy.h
@@ -97,7 +97,7 @@ private:
     // CoreIPC message handlers.
     // FIXME: These should be pure virtual.
     virtual void update(uint64_t sequenceNumber, const UpdateInfo&) { }
-    virtual void didSetSize(uint64_t sequenceNumber, const UpdateInfo&) { }
+    virtual void didSetSize(uint64_t sequenceNumber, const UpdateInfo&, const LayerTreeContext&) { }
 #if USE(ACCELERATED_COMPOSITING)
     virtual void enterAcceleratedCompositingMode(uint64_t sequenceNumber, const LayerTreeContext&) { }
     virtual void exitAcceleratedCompositingMode(uint64_t sequenceNumber) { }

But it is forward declared inside the guards in the same file.
Comment 1 Alejandro G. Castro 2011-02-08 09:03:35 PST 
Created attachment 81643 [details]
Proposed patch
Comment 2 Alejandro G. Castro 2011-02-08 23:22:41 PST 
Landed http://trac.webkit.org/changeset/78021