Bug 54005 - ASSERTION FAILURE: ASSERT_NOT_REACHED() in Connection::writeEventHandler() after the Web Process crashes
Summary: ASSERTION FAILURE: ASSERT_NOT_REACHED() in Connection::writeEventHandler() af...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Windows 7
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-02-08 08:03 PST by Jessie Berlin
Modified: 2011-02-08 08:59 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2011-02-08 08:08 PST, Jessie Berlin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2011-02-08 08:03:43 PST 
In ConnectionWin's Connection::writeEventHandler(), the error returned from ::GetLastError is ERROR_BROKEN_PIPE.

This is pretty logical, since the Web Process just crashed. We should handle this case by calling connectionDidClose() and returning.
Comment 1 Jessie Berlin 2011-02-08 08:06:25 PST 
<rdar://problem/8971458>
Comment 2 Jessie Berlin 2011-02-08 08:08:01 PST 
Created attachment 81637 [details]
Patch
Comment 3 Jessie Berlin 2011-02-08 08:35:12 PST 
Comment on attachment 81637 [details]
Patch

Committed in r77942
http://trac.webkit.org/changeset/77942
Comment 4 WebKit Review Bot 2011-02-08 08:59:13 PST 
http://trac.webkit.org/changeset/77942 might have broken Qt Linux Release
The following tests are not passing:
http/tests/websocket/tests/workers/close-in-onmessage-crash.html