RESOLVED DUPLICATE of bug 53175 53994
PlatformCAAnimation(const PlatformCAAnimation*) on Mac leaks, doesn't work correctly 
https://bugs.webkit.org/show_bug.cgi?id=53994
Summary PlatformCAAnimation(const PlatformCAAnimation*) on Mac leaks, doesn't work co...
Adam Roben (:aroben)
Reported 2011-02-08 04:59:17 PST
The PlatformCAAnimation(const PlatformCAAnimation*) constructor on Mac [1] leaks and doesn't initialize the PlatformCAAnimation correctly. Rather than initializing "this", it creates and throws away a new PlatformCAAnimation object. This results in leaks [2], and I can only assume results in incorrect rendering. 1. http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm?rev=73731#L190 2. http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r77920%20(14677)/DumpRenderTree-leaks.txt
Attachments
Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-02-08 04:59:48 PST
<rdar://problem/8971075>
Adam Roben (:aroben)
Comment 2 2011-02-08 06:57:14 PST
Seems like this function could be implemented as simply as: m_type = animation->animationType(); m_animation.adoptNS([animation->platformAnimation() copy]);
Adam Roben (:aroben)
Comment 3 2011-02-08 06:58:03 PST
I wonder if PlatformCAAnimation(PlatformAnimationRef) should be using -copy, too?
Simon Fraser (smfr)
Comment 4 2011-02-08 08:36:39 PST
*** This bug has been marked as a duplicate of bug 53175 ***
Note You need to log in before you can comment on or make changes to this bug.