Bug 53984 - Remove orphan code from old parser
: Remove orphan code from old parser
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-02-08 00:00 PST by
Modified: 2011-02-08 13:34 PST (History)


Attachments
Patch (20.15 KB, patch)
2011-02-08 00:02 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff
Patch (22.81 KB, patch)
2011-02-08 09:43 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-02-08 00:00:43 PST
Remove orphan code from old parser
------- Comment #1 From 2011-02-08 00:02:06 PST -------
Created an attachment (id=81607) [details]
Patch
------- Comment #2 From 2011-02-08 00:11:34 PST -------
(From update of attachment 81607 [details])
OK.
------- Comment #3 From 2011-02-08 00:20:45 PST -------
Attachment 81607 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7862004
------- Comment #4 From 2011-02-08 00:23:01 PST -------
(From update of attachment 81607 [details])
cq-, because it broke Qt build
------- Comment #5 From 2011-02-08 00:27:33 PST -------
(In reply to comment #4)
> (From update of attachment 81607 [details] [details])
> cq-, because it broke Qt build

It seems it isn't a Qt related problem, but a general WebKit2 releated problem:
Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h needs HTMLParserQuirks
------- Comment #6 From 2011-02-08 00:32:29 PST -------
Attachment 81607 [details] did not build on win:
Build output: http://queues.webkit.org/results/7756007
------- Comment #7 From 2011-02-08 03:53:23 PST -------
Attachment 81607 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7797047
------- Comment #8 From 2011-02-08 09:43:07 PST -------
Created an attachment (id=81654) [details]
Patch
------- Comment #9 From 2011-02-08 10:08:20 PST -------
(From update of attachment 81654 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=81654&action=review

> Source/WebCore/html/HTMLParserErrorCodes.cpp:-34
> -        "%tag1 is not allowed inside %tag2. Moving %tag1 into the nearest enclosing <table>.",

Do we still get error messages like this in the web inspector, or did we lose that feature when we added the new parser?
------- Comment #10 From 2011-02-08 12:17:26 PST -------
(From update of attachment 81654 [details])
Clearing flags on attachment: 81654

Committed r77963: <http://trac.webkit.org/changeset/77963>
------- Comment #11 From 2011-02-08 12:17:31 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #12 From 2011-02-08 12:56:35 PST -------
(In reply to comment #9)
> (From update of attachment 81654 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81654&action=review
> 
> > Source/WebCore/html/HTMLParserErrorCodes.cpp:-34
> > -        "%tag1 is not allowed inside %tag2. Moving %tag1 into the nearest enclosing <table>.",
> 
> Do we still get error messages like this in the web inspector, or did we lose that feature when we added the new parser?

Yes, we lost all HTML error reporting with the new parser.  Adam has a patch up for review which adds the first of it back.

(Entertainingly, it took over 6 months to notice.)

The new parser is designed with reporting in mind.  We mostly didn't implement it at the time due to lack of testing (it was not on the critical path).
------- Comment #13 From 2011-02-08 13:34:08 PST -------
Implementing parse error reporting is in https://bugs.webkit.org/show_bug.cgi?id=41187