Bug 53984 – Remove orphan code from old parser

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Remove orphan code from old parser

[Adam Barth]

Created attachment 81607 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 81607 [details]
Patch

OK.

[Early Warning System Bot]

Attachment 81607 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7862004

[Csaba Osztrogonác]

Comment on attachment 81607 [details]
Patch

cq-, because it broke Qt build

[Csaba Osztrogonác]

(In reply to comment #4)
> (From update of attachment 81607 [details])
> cq-, because it broke Qt build

It seems it isn't a Qt related problem, but a general WebKit2 releated problem:
Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h needs HTMLParserQuirks

[Build Bot]

Attachment 81607 [details] did not build on win:
Build output: http://queues.webkit.org/results/7756007

[WebKit Review Bot]

Attachment 81607 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7797047

[Adam Barth]

Created attachment 81654 [details]
Patch

[Darin Adler]

Comment on attachment 81654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81654&action=review

> Source/WebCore/html/HTMLParserErrorCodes.cpp:-34
> -        "%tag1 is not allowed inside %tag2. Moving %tag1 into the nearest enclosing <table>.",

Do we still get error messages like this in the web inspector, or did we lose that feature when we added the new parser?

[WebKit Commit Bot]

Comment on attachment 81654 [details]
Patch

Clearing flags on attachment: 81654

Committed r77963: <http://trac.webkit.org/changeset/77963>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

(In reply to comment #9)
> (From update of attachment 81654 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81654&action=review
> 
> > Source/WebCore/html/HTMLParserErrorCodes.cpp:-34
> > -        "%tag1 is not allowed inside %tag2. Moving %tag1 into the nearest enclosing <table>.",
> 
> Do we still get error messages like this in the web inspector, or did we lose that feature when we added the new parser?

Yes, we lost all HTML error reporting with the new parser.  Adam has a patch up for review which adds the first of it back.

(Entertainingly, it took over 6 months to notice.)

The new parser is designed with reporting in mind.  We mostly didn't implement it at the time due to lack of testing (it was not on the critical path).

[Adam Barth]

Implementing parse error reporting is in https://bugs.webkit.org/show_bug.cgi?id=41187