Bug 53977 - stop generating results.json files
Summary: stop generating results.json files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-07 22:36 PST by Ojan Vafai
Modified: 2011-02-08 21:04 PST (History)
4 users (show)

See Also:


Attachments
Patch (16.18 KB, patch)
2011-02-07 22:37 PST, Ojan Vafai
mihai: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-02-07 22:36:09 PST
stop generating results.json files
Comment 1 Ojan Vafai 2011-02-07 22:37:42 PST
Created attachment 81587 [details]
Patch
Comment 2 Mihai Parparita 2011-02-07 22:47:48 PST
Comment on attachment 81587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81587&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:172
>      def generate_json_output(self):

Seems like there should be a round of renaming (since these method names are very generic, and we're going to want more JSON generation code for the results.html replacement), but that can be done separately later (curious to see if anything breaks because of this change).
Comment 3 Ojan Vafai 2011-02-08 20:33:15 PST
Committed r78012: <http://trac.webkit.org/changeset/78012>
Comment 4 Kinuko Yasuda 2011-02-08 21:04:43 PST
(In reply to comment #3)
> Committed r78012: <http://trac.webkit.org/changeset/78012>

Awesome, thanks for doing this.