Bug 53975 – Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jeremy Orlow]

Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)

[Jeremy Orlow]

Created attachment 81580 [details]
Patch

[Jeremy Orlow]

please review

[WebKit Review Bot]

Attachment 81580 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7740009

[WebKit Review Bot]

Attachment 81580 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7828007

[Jeremy Orlow]

Created attachment 81708 [details]
Patch

[Nate Chapin]

Comment on attachment 81708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81708&action=review

> Source/WebCore/storage/IDBDatabase.cpp:143
> +ScriptExecutionContext* IDBDatabase::scriptExecutionContext() const
> +{
> +    return ActiveDOMObject::scriptExecutionContext();
> +}

Is there a reason we're overriding this if we're just calling straight to ActiveDOMObject?

> Source/WebCore/storage/IDBRequest.cpp:150
> +        // If there ever are events that are associated with a database but not have a

Grammar nit: "but not have" -> "but do not have"

> Source/WebCore/storage/IDBTransaction.cpp:116
> +ScriptExecutionContext* IDBTransaction::scriptExecutionContext() const
> +{
> +    return ActiveDOMObject::scriptExecutionContext();
> +}
> +

Same as above: is there a reason for this?  Am I missing something obvious?

[Jeremy Orlow]

(In reply to comment #6)
> (From update of attachment 81708 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81708&action=review
> 
> > Source/WebCore/storage/IDBDatabase.cpp:143
> > +ScriptExecutionContext* IDBDatabase::scriptExecutionContext() const
> > +{
> > +    return ActiveDOMObject::scriptExecutionContext();
> > +}
> 
> Is there a reason we're overriding this if we're just calling straight to ActiveDOMObject?

In eventTarget.h:
virtual ScriptExecutionContext* scriptExecutionContext() const = 0;

[Jeremy Orlow]

Committed r78005: <http://trac.webkit.org/changeset/78005>

[Zhenyao Mo]

storage/indexeddb/request-event-propagation.html
storage/indexeddb/transaction-event-propagation.html

are failing on chromium+webkit bots.