Bug 53952 - Add bundle API to get the background color of a frame
Summary: Add bundle API to get the background color of a frame
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
Depends on:
Reported: 2011-02-07 15:10 PST by Sam Weinig
Modified: 2011-02-07 15:46 PST (History)
0 users

See Also:

Patch (4.31 KB, patch)
2011-02-07 15:11 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (4.53 KB, patch)
2011-02-07 15:43 PST, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-02-07 15:10:33 PST
Add bundle API to get the background color of a frame
Comment 1 Sam Weinig 2011-02-07 15:11:34 PST
Created attachment 81537 [details]
Comment 2 Anders Carlsson 2011-02-07 15:14:55 PST
Comment on attachment 81537 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=81537&action=review

> Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:527
> +

All these early returns will cause the out parameters to be uninitialized. Can m_coreFrame ever be null? 

Should we make getBodyBackgroundColor return whether it was successful or not?

> Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:531
> +    *alpha = color.alpha();

We want the color components to be between 0 and 1, this doesn't do that.
Comment 3 Sam Weinig 2011-02-07 15:43:36 PST
Created attachment 81543 [details]
Comment 4 Sam Weinig 2011-02-07 15:46:30 PST
Landed in r77856.