Bug 53929 - check-style should not complain about code in icu directories
Summary: check-style should not complain about code in icu directories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-07 10:47 PST by Darin Adler
Modified: 2016-12-15 19:36 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2016-12-15 19:24 PST, Daniel Bates 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-02-07 10:47:57 PST 
check-style should not complain about pasted ICU code in UnicodeMacrosFromICU.h; those are using the ICU style
Comment 1 Daniel Bates 2016-12-15 19:18:59 PST 
(In reply to comment #0)
> check-style should not complain about pasted ICU code in
> UnicodeMacrosFromICU.h; those are using the ICU style

UnicodeMacrosFromICU.h was removed in the patch for bug #128106, <https://trac.webkit.org/changeset/163315>. Having said that we still have imported ICU headers, say in Source/WebCore/icu, and check-webkit-style should not warn about style issues in such files.
Comment 2 Daniel Bates 2016-12-15 19:20:35 PST 
For completeness, this issue caught my eye because of the deluge of style issues reported on each iteration of the patch for bug #160629 (attachment 297271 [details]), which imports more ICU headers.
Comment 3 Daniel Bates 2016-12-15 19:24:54 PST 
Created attachment 297287 [details]
Patch
Comment 4 Joseph Pecoraro 2016-12-15 19:30:45 PST 
Comment on attachment 297287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297287&action=review

> Tools/Scripts/webkitpy/style/checker.py:327
> +  ]

Style: Indentation of this seems weird. Should this have 4 spaces like the block below this?
Comment 5 Daniel Bates 2016-12-15 19:35:09 PST 
(In reply to comment #4)
> Comment on attachment 297287 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297287&action=review
> 
> > Tools/Scripts/webkitpy/style/checker.py:327
> > +  ]
> 
> Style: Indentation of this seems weird. Should this have 4 spaces like the
> block below this?

Wow, style bot failure. Will fix.
Comment 6 Daniel Bates 2016-12-15 19:36:37 PST 
Committed r209902: <http://trac.webkit.org/changeset/209902>