Bug 53928 - [Mac] spatial navigation is not set to false in DumpRenderTree explicitly
Summary: [Mac] spatial navigation is not set to false in DumpRenderTree explicitly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks: 49261
  Show dependency tree / graph
 
Reported: 2011-02-07 10:36 PST by Chang Shu
Modified: 2011-02-07 13:41 PST (History)
3 users (show)

See Also:

Attachments
fix patch (1.31 KB, patch)
2011-02-07 10:47 PST, Chang Shu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-02-07 10:36:28 PST 
The preference in DumpRenderTree (Mac version) is missing a call to [preferences setSpatialNavigationEnabled:NO].
This may cause flaky tests where spatial navigation is enabled by accident.
Comment 1 Chang Shu 2011-02-07 10:47:51 PST 
Created attachment 81491 [details]
fix patch
Comment 2 Chang Shu 2011-02-07 12:52:06 PST 
Comment on attachment 81491 [details]
fix patch

Clearing flags on attachment: 81491

Committed r77836: <http://trac.webkit.org/changeset/77836>
Comment 3 Chang Shu 2011-02-07 12:53:16 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2011-02-07 13:21:04 PST 
http://trac.webkit.org/changeset/77836 might have broken Qt Linux Release
Comment 5 Chang Shu 2011-02-07 13:41:19 PST 
(In reply to comment #4)
> http://trac.webkit.org/changeset/77836 might have broken Qt Linux Release

The patch only touches one .mm file. It shouldn't break Qt builds or tests.