Bug 53921 - [Qt] fast/dom/nodesFromRect-links-and-text.html crashes in debug mode
Summary: [Qt] fast/dom/nodesFromRect-links-and-text.html crashes in debug mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 48957 53488
  Show dependency tree / graph
 
Reported: 2011-02-07 09:24 PST by Csaba Osztrogonác
Modified: 2011-02-09 03:21 PST (History)
2 users (show)

See Also:

Attachments
GDB backtrace in debug mode (r53488) (8.88 KB, text/plain)
2011-02-07 09:24 PST, Csaba Osztrogonác 		no flags Details
Patch (3.04 KB, patch)
2011-02-08 11:44 PST, Robert Hogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-02-07 09:24:20 PST 
Created attachment 81480 [details]
GDB backtrace in debug mode (r53488)

fast/dom/nodesFromRect-links-and-text.html crashes in debug 
mode because of an assertion. (long long time ago)

GDB backtrace: <attached> (r53488)
Comment 1 Antonio Gomes 2011-02-07 09:30:07 PST 
Robert, it sounds related to your change.
Comment 2 Csaba Osztrogonác 2011-02-07 09:33:05 PST 
(In reply to comment #1)
> Robert, it sounds related to your change.

Yes. I got it, it crashed from http://trac.webkit.org/changeset/75189 .
Comment 3 Robert Hogan 2011-02-08 11:44:25 PST 
Created attachment 81671 [details]
Patch
Comment 4 Robert Hogan 2011-02-08 11:45:28 PST 
(In reply to comment #1)
> Robert, it sounds related to your change.

Yes siree, missed the copy constructor for QDRTNode. QVariant uses it.
Comment 5 Antonio Gomes 2011-02-08 13:09:44 PST 
Comment on attachment 81671 [details]
Patch

Do you need to upskip a tesT?
Comment 6 Csaba Osztrogonác 2011-02-09 03:12:29 PST 
(In reply to comment #5)
> (From update of attachment 81671 [details])
> Do you need to upskip a tesT?

No, fast/dom/nodesFromRect-links-and-text.html isn't on the 
Skipped list, it caused assertion only on the debug bot.
Comment 7 Csaba Osztrogonác 2011-02-09 03:21:24 PST 
Landed in http://trac.webkit.org/changeset/78038 .

Thanks for the quick fix.