RESOLVED FIXED 53883
[WIN] Add missing includes and forward declarations for CFNetwork 
https://bugs.webkit.org/show_bug.cgi?id=53883
Summary [WIN] Add missing includes and forward declarations for CFNetwork
Patrick R. Gansterer
Reported 2011-02-06 11:42:01 PST
see patch
Attachments
Patch (1.59 KB, patch)
2011-02-06 11:43 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (1.72 KB, patch)
2011-02-06 13:38 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (3.53 KB, patch)
2011-02-06 15:49 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-02-06 11:43:29 PST
Created attachment 81420 [details] Patch
WebKit Review Bot
Comment 2 2011-02-06 13:07:00 PST
Attachment 81420 [details] did not build on mac: Build output: http://queues.webkit.org/results/7700652
Patrick R. Gansterer
Comment 3 2011-02-06 13:38:01 PST
Created attachment 81425 [details] Patch
Patrick R. Gansterer
Comment 4 2011-02-06 15:49:53 PST
Created attachment 81430 [details] Patch
Adam Roben (:aroben)
Comment 5 2011-02-07 07:40:13 PST
Comment on attachment 81430 [details] Patch None of these #includes or forward-declarations is required on Windows because we pull them in through our prefix header. My guess is that adding them here will just slow the build down with no positive effect. In what situation are these #includes and forward-declarations useful?
Eric Seidel (no email)
Comment 6 2011-02-07 15:19:14 PST
Comment on attachment 81430 [details] Patch I suspect patrick is trying to build without a prefix header. These includes make sense to me, but I don't work on the windows port anymore so I defer to those who do.
Adam Roben (:aroben)
Comment 7 2011-02-08 06:55:49 PST
Comment on attachment 81430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81430&action=review > Source/WebCore/platform/network/cf/DNSCFNet.cpp:39 > #if PLATFORM(WIN) > #include "LoaderRunLoopCF.h" > +#include <CFNetwork/CFNetwork.h> Why only do this for PLATFORM(WIN)? > Source/WebCore/platform/network/cf/ProxyServerCFNet.cpp:34 > +#if PLATFORM(WIN) > +#include <CFNetwork/CFNetwork.h> > +#endif Why only do this for PLATFORM(WIN)? > Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp:50 > #if PLATFORM(WIN) > #include "LoaderRunLoopCF.h" > +#include <CFNetwork/CFNetwork.h> Why only do this for PLATFORM(WIN)?
Patrick R. Gansterer
Comment 8 2011-02-08 06:59:33 PST
Comment on attachment 81430 [details] Patch (In reply to comment #7) > (From update of attachment 81430 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81430&action=review > > > Source/WebCore/platform/network/cf/DNSCFNet.cpp:39 > > #if PLATFORM(WIN) > > #include "LoaderRunLoopCF.h" > > +#include <CFNetwork/CFNetwork.h> > > Why only do this for PLATFORM(WIN)? It's a private header on Mac.
WebKit Commit Bot
Comment 9 2011-02-08 07:59:07 PST
Comment on attachment 81430 [details] Patch Clearing flags on attachment: 81430 Committed r77937: <http://trac.webkit.org/changeset/77937>
WebKit Commit Bot
Comment 10 2011-02-08 07:59:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.