Bug 53883 - [WIN] Add missing includes and forward declarations for CFNetwork
Summary: [WIN] Add missing includes and forward declarations for CFNetwork
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-06 11:42 PST by Patrick R. Gansterer
Modified: 2011-02-08 07:59 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2011-02-06 11:43 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (1.72 KB, patch)
2011-02-06 13:38 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (3.53 KB, patch)
2011-02-06 15:49 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-02-06 11:42:01 PST
see patch
Comment 1 Patrick R. Gansterer 2011-02-06 11:43:29 PST
Created attachment 81420 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-06 13:07:00 PST
Attachment 81420 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7700652
Comment 3 Patrick R. Gansterer 2011-02-06 13:38:01 PST
Created attachment 81425 [details]
Patch
Comment 4 Patrick R. Gansterer 2011-02-06 15:49:53 PST
Created attachment 81430 [details]
Patch
Comment 5 Adam Roben (:aroben) 2011-02-07 07:40:13 PST
Comment on attachment 81430 [details]
Patch

None of these #includes or forward-declarations is required on Windows because we pull them in through our prefix header. My guess is that adding them here will just slow the build down with no positive effect. In what situation are these #includes and forward-declarations useful?
Comment 6 Eric Seidel (no email) 2011-02-07 15:19:14 PST
Comment on attachment 81430 [details]
Patch

I suspect patrick is trying to build without a prefix header.  These includes make sense to me, but I don't work on the windows port anymore so I defer to those who do.
Comment 7 Adam Roben (:aroben) 2011-02-08 06:55:49 PST
Comment on attachment 81430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81430&action=review

> Source/WebCore/platform/network/cf/DNSCFNet.cpp:39
>  #if PLATFORM(WIN)
>  #include "LoaderRunLoopCF.h"
> +#include <CFNetwork/CFNetwork.h>

Why only do this for PLATFORM(WIN)?

> Source/WebCore/platform/network/cf/ProxyServerCFNet.cpp:34
> +#if PLATFORM(WIN)
> +#include <CFNetwork/CFNetwork.h>
> +#endif

Why only do this for PLATFORM(WIN)?

> Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp:50
>  #if PLATFORM(WIN)
>  #include "LoaderRunLoopCF.h"
> +#include <CFNetwork/CFNetwork.h>

Why only do this for PLATFORM(WIN)?
Comment 8 Patrick R. Gansterer 2011-02-08 06:59:33 PST
Comment on attachment 81430 [details]
Patch

(In reply to comment #7)
> (From update of attachment 81430 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81430&action=review
> 
> > Source/WebCore/platform/network/cf/DNSCFNet.cpp:39
> >  #if PLATFORM(WIN)
> >  #include "LoaderRunLoopCF.h"
> > +#include <CFNetwork/CFNetwork.h>
> 
> Why only do this for PLATFORM(WIN)?

It's a private header on Mac.
Comment 9 WebKit Commit Bot 2011-02-08 07:59:07 PST
Comment on attachment 81430 [details]
Patch

Clearing flags on attachment: 81430

Committed r77937: <http://trac.webkit.org/changeset/77937>
Comment 10 WebKit Commit Bot 2011-02-08 07:59:13 PST
All reviewed patches have been landed.  Closing bug.