Bug 53881 - [WIN] Add missing includes and forward declarations for DownloadBundle
Summary: [WIN] Add missing includes and forward declarations for DownloadBundle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-06 11:30 PST by Patrick R. Gansterer
Modified: 2011-02-08 08:50 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.49 KB, patch)
2011-02-06 11:32 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (2.49 KB, patch)
2011-02-06 14:35 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-02-06 11:30:25 PST
see patch
Comment 1 Patrick R. Gansterer 2011-02-06 11:32:42 PST
Created attachment 81417 [details]
Patch
Comment 2 Patrick R. Gansterer 2011-02-06 14:35:13 PST
Created attachment 81428 [details]
Patch
Comment 3 Adam Roben (:aroben) 2011-02-07 07:38:28 PST
Comment on attachment 81428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81428&action=review

> Source/WebCore/platform/network/cf/DownloadBundle.h:31
> +typedef const struct __CFData* CFDataRef;

Why is this needed? On Windows we pull in CoreFoundation.h through our prefix header.

> Source/WebCore/platform/network/win/DownloadBundleWin.cpp:29
> +#include <CoreFoundation/CoreFoundation.h>

Same question.

> Source/WebCore/platform/network/win/DownloadBundleWin.cpp:32
> +#include <sys/stat.h>
> +#include <sys/types.h>

Presumably these are getting pulled in through the prefix header on Windows, too.
Comment 4 WebKit Commit Bot 2011-02-08 08:50:28 PST
Comment on attachment 81428 [details]
Patch

Clearing flags on attachment: 81428

Committed r77944: <http://trac.webkit.org/changeset/77944>
Comment 5 WebKit Commit Bot 2011-02-08 08:50:32 PST
All reviewed patches have been landed.  Closing bug.